Skip to content

[CI] Maintenance: align ruby versions - #468

Merged
kieran-osgood-shopify merged 1 commit into
mainfrom
kieran-osgood/07-15-featalignrubyversions
Jul 15, 2026
Merged

[CI] Maintenance: align ruby versions#468
kieran-osgood-shopify merged 1 commit into
mainfrom
kieran-osgood/07-15-featalignrubyversions

Conversation

@kieran-osgood-shopify

@kieran-osgood-shopify kieran-osgood-shopify commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

What changes are you making?

Aligns the ruby versions across the repo by symlinking the .ruby-version files together (certain tools like github ruby version expects it in the working-directory its targeted to which would be platforms/swift / platforms/react-native

By aligning to 3.4 this actually allows us to get fast builds on CI because asdf doesn't have to compile non-aliased preinstalled versions on bitrise

How to test


Before you merge

Important

  • I've added tests to support my implementation
  • I have read and agree with the Contribution Guidelines
  • I have read and agree with the Code of Conduct
  • I've updated the relevant platform README (platforms/swift/README.md and/or platforms/android/README.md)

Releasing a new Swift version?
  • I have bumped the version in ShopifyCheckoutKit.podspec
  • I have bumped the version in platforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swift
  • I have updated the SwiftPM/CocoaPods version snippets in platforms/swift/README.md (major version only)
Releasing a new Embedded Checkout Protocol version?
  • I have bumped embeddedCheckoutProtocolAndroid in platforms/android/gradle/libs.versions.toml
  • I have updated protocol/languages/kotlin/embedded-checkout-protocol/api/embedded-checkout-protocol.api if the public API changed
Releasing a new Android version?
  • I have bumped checkoutKitAndroid in platforms/android/gradle/libs.versions.toml
  • I have updated the Gradle/Maven version snippets in platforms/android/README.md

Tip

See the Contributing documentation for the full release process per platform.

@github-actions github-actions Bot added the #gsd:50662 Rebase Checkout Kit on UCP label Jul 15, 2026
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/07-15-featalignrubyversions branch from f15ca19 to a1b3fe7 Compare July 15, 2026 11:38
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/07-15-feataddswifte2etest branch 2 times, most recently from 5e13572 to 483db53 Compare July 15, 2026 13:41
@kieran-osgood-shopify
kieran-osgood-shopify marked this pull request as ready for review July 15, 2026 13:41
@kieran-osgood-shopify
kieran-osgood-shopify requested a review from a team as a code owner July 15, 2026 13:41
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/07-15-feataddswifte2etest branch from 483db53 to 5084a63 Compare July 15, 2026 13:42
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/07-15-featalignrubyversions branch from a1b3fe7 to 743704c Compare July 15, 2026 13:42
@github-actions

github-actions Bot commented Jul 15, 2026

Copy link
Copy Markdown

React Native — Coverage Report

Lines Statements Branches Functions
Coverage: 92%
91.85% (327/356) 87.98% (183/208) 100% (86/86)

@github-actions

Copy link
Copy Markdown

Package Size

Platform Artifact Base Head Delta
React Native npm tarball 103.1 KiB 103.1 KiB 0 B
React Native file breakdown
File Base Head Delta
node_modules/@shopify/checkout-kit-protocol/src/generated/Models.ts 85.4 KiB 85.4 KiB 0 B
node_modules/@shopify/checkout-kit-protocol/src/generated/Models.d.ts 53.0 KiB 53.0 KiB 0 B
ios/ShopifyCheckoutKit.swift 15.0 KiB 15.0 KiB 0 B
ios/AcceleratedCheckoutButtons.swift 14.0 KiB 14.0 KiB 0 B
lib/commonjs/index.js 13.1 KiB 13.1 KiB 0 B
src/components/AcceleratedCheckoutButtons.tsx 12.9 KiB 12.9 KiB 0 B
src/index.ts 12.5 KiB 12.5 KiB 0 B
lib/commonjs/components/AcceleratedCheckoutButtons.js 11.4 KiB 11.4 KiB 0 B
android/src/main/java/com/shopify/reactnative/checkoutkit/ShopifyCheckoutKitModule.java 11.1 KiB 11.1 KiB 0 B
lib/module/index.js 10.4 KiB 10.4 KiB 0 B
lib/commonjs/components/AcceleratedCheckoutButtons.js.map 10.3 KiB 10.3 KiB 0 B
lib/module/components/AcceleratedCheckoutButtons.js 10.2 KiB 10.2 KiB 0 B
node_modules/@shopify/checkout-kit-protocol/src/generated/ProtocolNotifications.ts 9.5 KiB 9.5 KiB 0 B
lib/module/components/AcceleratedCheckoutButtons.js.map 9.1 KiB 9.1 KiB 0 B
src/index.d.ts 8.9 KiB 8.9 KiB 0 B
lib/module/index.js.map 8.2 KiB 8.2 KiB 0 B
src/present-dispatcher.ts 8.0 KiB 8.0 KiB 0 B
lib/commonjs/index.js.map 7.7 KiB 7.7 KiB 0 B
node_modules/@shopify/checkout-kit-protocol/src/generated/ProtocolNotifications.d.ts 7.6 KiB 7.6 KiB 0 B
node_modules/@shopify/checkout-kit-protocol/src/generated/ProtocolRenameMap.ts 7.2 KiB 7.2 KiB 0 B
…and 110 smaller files

Measured from the PR base SHA and PR head SHA. The file breakdown shows uncompressed sizes within each package artifact, so individual files do not sum to the compressed artifact total. This comment reports package artifact sizes only; it is not a final app binary-size report.

@@ -0,0 +1 @@
../../../.ruby-version No newline at end of file

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

symlinked this to match the root ruby-version
the github actions rely on working-directory - which expects a .ruby-version in that working directory and cannot reference the root one

@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/07-15-featalignrubyversions branch from 743704c to 0e7fa25 Compare July 15, 2026 14:25
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/07-15-feataddswifte2etest branch 2 times, most recently from 1803629 to fb39879 Compare July 15, 2026 15:03
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/07-15-featalignrubyversions branch from 0e7fa25 to d3c32c4 Compare July 15, 2026 15:03

kieran-osgood-shopify commented Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

Merge activity

  • Jul 15, 4:40 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jul 15, 4:42 PM UTC: Graphite rebased this pull request as part of a merge.
  • Jul 15, 5:06 PM UTC: Graphite couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'CI Required', 'Swift / build-samples / Build Sample Apps').

@kieran-osgood-shopify
kieran-osgood-shopify changed the base branch from kieran-osgood/07-15-feataddswifte2etest to graphite-base/468 July 15, 2026 16:41
@kieran-osgood-shopify
kieran-osgood-shopify changed the base branch from graphite-base/468 to main July 15, 2026 16:41
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/07-15-featalignrubyversions branch from d3c32c4 to 5d42bde Compare July 15, 2026 16:41
@kieran-osgood-shopify
kieran-osgood-shopify merged commit 37311ee into main Jul 15, 2026
57 of 59 checks passed
@kieran-osgood-shopify
kieran-osgood-shopify deleted the kieran-osgood/07-15-featalignrubyversions branch July 15, 2026 18:24
@kieran-osgood-shopify kieran-osgood-shopify changed the title feat: align ruby versions [CI] Maintenance: align ruby versions Jul 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

#gsd:50662 Rebase Checkout Kit on UCP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants