[Android][Swift] Rename oncancel to ondismiss in swift and android - #482
Merged
kiftio merged 1 commit intoJul 17, 2026
Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
kiftio
force-pushed
the
07-16-rename_oncancel_to_ondismiss_in_swift_and_android
branch
2 times, most recently
from
July 16, 2026 11:10
2bebe9a to
b341fdf
Compare
11 tasks
kiftio
force-pushed
the
07-16-rename_oncancel_to_ondismiss_in_swift_and_android
branch
from
July 16, 2026 11:21
b341fdf to
39006d4
Compare
11 tasks
kiftio
marked this pull request as ready for review
July 16, 2026 12:11
kiftio
force-pushed
the
07-16-rename_oncancel_to_ondismiss_in_swift_and_android
branch
from
July 16, 2026 12:25
39006d4 to
4a5a483
Compare
Package Size
Android file breakdown
Measured from the PR base SHA and PR head SHA. The file breakdown shows uncompressed sizes within each package artifact, so individual files do not sum to the compressed artifact total. This comment reports package artifact sizes only; it is not a final app binary-size report. |
kiftio
force-pushed
the
07-16-rename_oncancel_to_ondismiss_in_swift_and_android
branch
2 times, most recently
from
July 17, 2026 13:02
147c9c4 to
2a90c2d
Compare
Install this buildOpen Tophat, select your target device, then click Install. Links open on the Mac running Tophat.
Checkout Kit E2E results
|
kiftio
force-pushed
the
07-16-rename_oncancel_to_ondismiss_in_swift_and_android
branch
from
July 17, 2026 13:24
2a90c2d to
79ed94c
Compare
markmur
approved these changes
Jul 17, 2026
kiftio
force-pushed
the
07-16-rename_oncancel_to_ondismiss_in_swift_and_android
branch
from
July 17, 2026 14:51
79ed94c to
5f70cee
Compare
kieran-osgood-shopify
approved these changes
Jul 17, 2026
Contributor
Author
kiftio
deleted the
07-16-rename_oncancel_to_ondismiss_in_swift_and_android
branch
July 17, 2026 16:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What changes are you making?
Renames the "cancel" terminology to "dismiss" across the Android and Swift SDKs to better reflect the user action of dismissing the checkout sheet rather than cancelling a transaction. This is particularly relevant when the buyer dismisses on the thank you page after a completed order.
**Note** Accelerated chekouts keeps
onCancelin this PR, that's happening in the next PRSpecifically:
CheckoutListener.onCheckoutCanceled()→onCheckoutDismissed(),CheckoutPresentation.onCancel {}→onDismiss {}, and all internal tracking variables (cancelNotified→dismissNotified), log messages, and helper methods (notifyCheckoutCanceled→notifyCheckoutDismissed,cancelAfterSheetDismissAnimation→dismissAfterSheetDismissAnimation) updated accordingly.CheckoutHostConfiguration.onCancelRequest→onDismissRequest.CheckoutDelegate.checkoutDidCancel()→checkoutDidDismiss(),ShopifyCheckout.onCancel {}→onDismiss {}, and the internalonCancelAction/onCancelwiring updated throughoutCheckoutViewControllerandCheckoutWebViewController. Swift API surface JSON updated to reflect the renamed symbols."Checkout canceled"→"Checkout dismissed"), and internal log context helpers (isCheckoutCancellation→isCheckoutDismissal,completedCheckoutIdForFollowUpCancellation→completedCheckoutIdForFollowUpDismissal).How to test
onDismissis invoked exactly once in each case.checkoutDidDismiss()is called in each case.onFail/checkoutDidFailis not triggered on a normal dismissal."Checkout dismissed".Before you merge
Important
platforms/swift/README.mdand/orplatforms/android/README.md)Releasing a new Swift version?
ShopifyCheckoutKit.podspecplatforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swiftplatforms/swift/README.md(major version only)Releasing a new Embedded Checkout Protocol version?
embeddedCheckoutProtocolAndroidinplatforms/android/gradle/libs.versions.tomlprotocol/languages/kotlin/embedded-checkout-protocol/api/embedded-checkout-protocol.apiif the public API changedReleasing a new Android version?
checkoutKitAndroidinplatforms/android/gradle/libs.versions.tomlplatforms/android/README.mdTip
See the Contributing documentation for the full release process per platform.