[Swift] Updates accelerated checkouts to use onDismiss - #486
Merged
kiftio merged 1 commit intoJul 17, 2026
Conversation
11 tasks
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
11 tasks
kiftio
force-pushed
the
07-16-updates_accelerated_checkouts_to_use_ondismiss
branch
from
July 16, 2026 12:25
e828251 to
1658436
Compare
kiftio
force-pushed
the
07-16-rename_oncancel_to_ondismiss_in_swift_and_android
branch
from
July 16, 2026 12:25
39006d4 to
4a5a483
Compare
kiftio
marked this pull request as ready for review
July 16, 2026 12:27
kiftio
force-pushed
the
07-16-updates_accelerated_checkouts_to_use_ondismiss
branch
from
July 16, 2026 12:51
1658436 to
80afddb
Compare
kiftio
changed the base branch from
07-16-rename_oncancel_to_ondismiss_in_swift_and_android
to
graphite-base/486
July 17, 2026 12:54
kiftio
force-pushed
the
07-16-updates_accelerated_checkouts_to_use_ondismiss
branch
from
July 17, 2026 13:02
80afddb to
fde85ba
Compare
kiftio
force-pushed
the
graphite-base/486
branch
from
July 17, 2026 13:02
4a5a483 to
2a90c2d
Compare
kiftio
changed the base branch from
graphite-base/486
to
07-16-rename_oncancel_to_ondismiss_in_swift_and_android
July 17, 2026 13:02
Install this buildOpen Tophat, select your target device, then click Install. Links open on the Mac running Tophat.
Checkout Kit E2E results
|
kiftio
force-pushed
the
07-16-updates_accelerated_checkouts_to_use_ondismiss
branch
from
July 17, 2026 13:14
fde85ba to
2006fbd
Compare
kiftio
force-pushed
the
07-16-rename_oncancel_to_ondismiss_in_swift_and_android
branch
from
July 17, 2026 13:24
2a90c2d to
79ed94c
Compare
kiftio
force-pushed
the
07-16-updates_accelerated_checkouts_to_use_ondismiss
branch
2 times, most recently
from
July 17, 2026 14:51
b179be8 to
9165564
Compare
kiftio
force-pushed
the
07-16-rename_oncancel_to_ondismiss_in_swift_and_android
branch
from
July 17, 2026 14:51
79ed94c to
5f70cee
Compare
kieran-osgood-shopify
approved these changes
Jul 17, 2026
Contributor
Author
kiftio
changed the base branch from
07-16-rename_oncancel_to_ondismiss_in_swift_and_android
to
graphite-base/486
July 17, 2026 16:08
kiftio
force-pushed
the
07-16-updates_accelerated_checkouts_to_use_ondismiss
branch
from
July 17, 2026 16:09
9165564 to
d445766
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What changes are you making?
Renames the
onCancel/checkoutDidCancelAPI toonDismiss/checkoutDidDismissacross the Swift platform to better reflect the intent of the callback. "Cancel" implied the buyer actively abandoned the checkout, whereas "dismiss" more accurately describes the action of closing the checkout experience regardless of the reason.This is a breaking API change that affects:
AcceleratedCheckoutButtons.onCancel(_:)view modifier, renamed toonDismiss(_:)EventHandlers.checkoutDidCancelproperty, renamed tocheckoutDidDismissApplePayViewController.onCheckoutCancelproperty, renamed toonCheckoutDismissHow to test
AcceleratedCheckoutButtonsinto a SwiftUI view and attach the.onDismiss { }modifier.onDismissclosure is invoked and the previousonCancelmodifier is no longer available.Before you merge
Important
platforms/swift/README.mdand/orplatforms/android/README.md)Releasing a new Swift version?
ShopifyCheckoutKit.podspecplatforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swiftplatforms/swift/README.md(major version only)Releasing a new Embedded Checkout Protocol version?
embeddedCheckoutProtocolAndroidinplatforms/android/gradle/libs.versions.tomlprotocol/languages/kotlin/embedded-checkout-protocol/api/embedded-checkout-protocol.apiif the public API changedReleasing a new Android version?
checkoutKitAndroidinplatforms/android/gradle/libs.versions.tomlplatforms/android/README.mdTip
See the Contributing documentation for the full release process per platform.