Fix fsspec S3 virtual addressing boolean parsing#3492
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
ebyhr
approved these changes
Jun 14, 2026
ebyhr
left a comment
ebyhr
left a comment
Member
There was a problem hiding this comment.
Looks good to me. I've confirmed that the added test fails without this PR's change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
FsspecFileIOcheckeds3.force-virtual-addressingwith raw property truthiness. That meant"false"still enabled virtual-host addressing because it is a non-empty string.This changes the fsspec S3 setup to use the existing boolean property parser, matching the rest of the codebase and preserving the default behavior when the property is absent.
Are these changes tested?
PYTHONPATH=. uv run --extra s3fs pytest tests/io/test_fsspec.py::test_fsspec_s3_session_properties_force_virtual_addressingPYTHONPATH=. uv run --extra s3fs pytest tests/io/test_fsspec.py -k "s3_session_properties"uv run prek run ruff --files pyiceberg/io/fsspec.py tests/io/test_fsspec.pyuv run prek run ruff-format --files pyiceberg/io/fsspec.py tests/io/test_fsspec.pyAre there any user-facing changes?
Yes. Setting
s3.force-virtual-addressing=falsefor fsspec S3 FileIO now leaves the default addressing behavior unchanged instead of forcing virtual addressing.