Skip to content

Fix fsspec S3 virtual addressing boolean parsing #3492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fallintoplace wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −4
Open

Fix fsspec S3 virtual addressing boolean parsing #3492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyiceberg/io/fsspec.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ def _s3(properties: Properties) -> AbstractFileSystem:
if request_timeout := properties.get(S3_REQUEST_TIMEOUT):
config_kwargs["read_timeout"] = float(request_timeout)

if _force_virtual_addressing := properties.get(S3_FORCE_VIRTUAL_ADDRESSING):
if property_as_bool(properties, S3_FORCE_VIRTUAL_ADDRESSING, False):
config_kwargs["s3"] = {"addressing_style": "virtual"}

if s3_anonymous := properties.get(S3_ANONYMOUS):
Expand Down
13 changes: 10 additions & 3 deletions tests/io/test_fsspec.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,9 +320,16 @@ def test_fsspec_s3_session_properties() -> None:
)


def test_fsspec_s3_session_properties_force_virtual_addressing() -> None:
@pytest.mark.parametrize(
("force_virtual_addressing", "config_kwargs"),
[
("true", {"s3": {"addressing_style": "virtual"}}),
("false", {}),
],
)
def test_fsspec_s3_session_properties_force_virtual_addressing(force_virtual_addressing: str, config_kwargs: Properties) -> None:
session_properties: Properties = {
"s3.force-virtual-addressing": True,
"s3.force-virtual-addressing": force_virtual_addressing,
"s3.endpoint": "http://localhost:9000",
"s3.access-key-id": "admin",
"s3.secret-access-key": "password",
Expand All @@ -346,7 +353,7 @@ def test_fsspec_s3_session_properties_force_virtual_addressing() -> None:
"region_name": "us-east-1",
"aws_session_token": "s3.session-token",
},
config_kwargs={"s3": {"addressing_style": "virtual"}},
config_kwargs=config_kwargs,
)


Expand Down