feat: Add REST loadCredentials support#3499
Open
kevinjqliu wants to merge 1 commit into
Open
Conversation
kevinjqliu
force-pushed
the
codex/load-credentials-api
branch
from
9cb70c8 to
69a6e5b
Compare
kevinjqliu
force-pushed
the
codex/load-credentials-api
branch
from
69a6e5b to
64d39b6
Compare
kevinjqliu
changed the title
ebyhr
approved these changes
Jun 13, 2026
|
|
||
| return ScanTasks.model_validate_json(response.text) | ||
|
|
||
| @retry(**_RETRY_ARGS) |
Member
There was a problem hiding this comment.
nit: These methods are added between _fetch_scan_tasks and plan_scan. These two methods are closely related. How about relocating these new methods to different locations?
Comment on lines
+561
to
+562
| response = self._session.get( | ||
| self.url(Endpoints.load_credentials, prefixed=True, **self._split_identifier_for_path(identifier)), |
Member
There was a problem hiding this comment.
Assuming we'll support optional parameters as a follow-up if necessary:
parameters:
- name: planId
in: query
required: false
schema:
type: string
description: The plan ID that has been used for server-side scan planning
- $ref: '#/components/parameters/referenced-by'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
loadCredentialsendpoint supportLoadCredentialsResponseRestCatalog.load_credentials(...)with longest-prefix resolution for a target locationContributes to #3495.
Notes
The pinned
apache/iceberg-rest-fixture:1.10.1used by integration tests does not serve the/credentialsroute, so this is covered with REST catalog unit tests rather than fixture-backed integration tests.Testing
PYTHONPATH=. pytest tests/catalog/test_rest.py -k 'load_credentials or storage_credentials'ruff check pyiceberg/catalog/rest/__init__.py tests/catalog/test_rest.pyruff format --check pyiceberg/catalog/rest/__init__.py tests/catalog/test_rest.py