Make sure nodes are using sim time if running in sim#1006
Open
MegaIng wants to merge 1 commit into
Open
Conversation
Flova
approved these changes
Jul 4, 2026
Member
|
We could also add it to the AGENTD.md or some other place so LLM reviews keep an eye on that in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Various nodes, especially the ones used internally by the custom transform buffers were not using sim time when running in sim. This almost surely has lead to various issues with additional transform errors that would not have happened IRL.
Proposed changes
I went through all nodes and made sure they use
use_sim_time=trueif in the correct context.Related issues
Checklist
pixi run build