test: Implement integration tests #289
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #289 +/- ##
===========================================
+ Coverage 24.79% 56.89% +32.10%
===========================================
Files 22 22
Lines 3678 3661 -17
===========================================
+ Hits 912 2083 +1171
+ Misses 2766 1578 -1188
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
b3ffd2d to
0329928
Compare
7 tasks
0329928 to
dfeb580
Compare
6 tasks
ff42ff3 to
5ea933b
Compare
- add BdkCli helper struct and impl methods - add integration tests for the key subcommand operations
- Add integration tests for wallets, descriptor, compile and config modules
- add integration tests for offline wallet operations
- Add test for creating, signing, broadcasting tx - Add test for combining psbt, fee bump and other psbt related commands - Add bip322 tests
- add saving proxy_opts for electrum and esplora clients to config and reading values - fix prepare_home_dir util fn
Multi-line description of commit, feel free to be detailed. [Ticket: X]
- add tests for OP_RETURN in createtx - add tests for coin selection in createtx - add test for esplora client full_scan - fix clippy issues
- The problem: When running `cargo test --all- features`, the backends (electrum, rpc, esplora from TestEnv) run in parallel at the number of cpus available and exhaust the processes/ports available, thereby resulting in os error 35. This fix limits the number of threads that are available for the tests to run in parallel.
5ea933b to
6000dd5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR builds on #278 and introduces integration tests for bdk-cli. It replaces manual
std::process::Commandboilerplate with theassert_cmdlibrary, allowing us to perform black-box testing against the compiled binary.Features covered so far include:
Notes to the reviewers
Changelog notice
verboseflag from wallets as it was applicable to onlyPbstChecklists
All Submissions:
cargo fmtandcargo clippybefore committing