Skip to content

primitives%feat(types): add new RFC predicates and use in is_reachable(), sync is_routable() with consensus definition#17

Open
kwvg wants to merge 3 commits into
dashpay:developfrom
kwvg:netroute
Open

primitives%feat(types): add new RFC predicates and use in is_reachable(), sync is_routable() with consensus definition#17
kwvg wants to merge 3 commits into
dashpay:developfrom
kwvg:netroute

Conversation

@kwvg

@kwvg kwvg commented Jun 28, 2026

Copy link
Copy Markdown
Collaborator

Additional Information

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional tests
  • I have made corresponding changes to the documentation (note: N/A)
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

@kwvg kwvg added this to the 0.1 milestone Jun 28, 2026
@kwvg kwvg self-assigned this Jun 28, 2026
@coderabbitai

coderabbitai Bot commented Jun 28, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@kwvg, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 59 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: eaf7e3af-a48a-480d-9d9b-221fa94090af

📥 Commits

Reviewing files that changed from the base of the PR and between 577a749 and 25e3568.

📒 Files selected for processing (2)
  • pkgs/primitives/src/types/addrv1.rs
  • pkgs/primitives/src/types/netaddr.rs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot removed the needs-rebase This pull request needs to be rebased against the base branch label Jun 30, 2026
@kwvg kwvg changed the title sdk%feat: impl {Array,Encode}Buf to limit avoidable heap allocs, add PoW check, add RFCs, is_reachable(), sync is_routable() primitives%feat(types): add new RFC predicates and use in is_reachable(), sync is_routable() with consensus definition Jun 30, 2026
@kwvg kwvg marked this pull request as ready for review June 30, 2026 11:02
@kwvg

kwvg commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant