Skip to content

sdk%feat: switch from {En,De}codable to {En,De}code, house KeyId in dash-script, adopt bitcoin_p2p_messages crate types into p2p_core#18

Draft
kwvg wants to merge 33 commits into
dashpay:developfrom
kwvg:encodable
Draft

sdk%feat: switch from {En,De}codable to {En,De}code, house KeyId in dash-script, adopt bitcoin_p2p_messages crate types into p2p_core#18
kwvg wants to merge 33 commits into
dashpay:developfrom
kwvg:encodable

Conversation

@kwvg

@kwvg kwvg commented Jun 28, 2026

Copy link
Copy Markdown
Collaborator

Additional Information

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

kwvg added 26 commits June 26, 2026 08:53
@kwvg kwvg added this to the 0.1 milestone Jun 28, 2026
@kwvg kwvg self-assigned this Jun 28, 2026
@coderabbitai

coderabbitai Bot commented Jun 28, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 76c91cd7-7db2-47c5-b76a-fcefc5197d44

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the needs-rebase This pull request needs to be rebased against the base branch label Jun 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-rebase This pull request needs to be rebased against the base branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant