[WIP] fix(ios): rendering hitches new arch#5
Draft
hannojg wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Performance changes
I implemented multiple fixers which helped drive down render-passes, offscreen render passes and masking (which often results in additional render passes).
With all those fixes, during scrolling the DM list to the bottom, the total offscreen render passes which are especially expensive went from:
1. Image component applied clipping and masks twice
27bc03f
RCTViewComponentView.mm is setting a mask when border radius is applied, however, the image in JS is wrapped with a parent view to which styles get applied and that one already does the border radius + clipping!
2. Interop layer was setting overflow/clipping twice
66ed378
It once set it on the native component and once on the interop intermediate view, causing double clipping.