Skip to content

fix(ios): rendering hitches new arch #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hannojg merged 3 commits into from
Jun 29, 2026
+13 −8
Merged

fix(ios): rendering hitches new arch #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
27bc03f
fix(ios): rendering hitches
hannojg Jun 26, 2026
66ed378
avoid setting overflow twice for Legacy Interop components
hannojg Jun 29, 2026
957f2f4
Revert "avoid setting overflow twice for Legacy Interop components"
hannojg Jun 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/react-native/React/Fabric/Mounting/ComponentViews/Image/RCTImageComponentView.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@ - (instancetype)initWithFrame:(CGRect)frame
_props = defaultProps;

_imageView = [RCTUIImageViewAnimated new];
_imageView.clipsToBounds = YES;
// Note(Discord/Hanno): This should not be needed as the JS layer sets overflow:hidden!
// _imageView.clipsToBounds = YES;
_imageView.contentMode = RCTContentModeFromImageResizeMode(defaultProps->resizeMode);
_imageView.layer.minificationFilter = kCAFilterTrilinear;
_imageView.layer.magnificationFilter = kCAFilterTrilinear;
Expand Down
18 changes: 11 additions & 7 deletions packages/react-native/React/Fabric/Mounting/ComponentViews/View/RCTViewComponentView.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1078,13 +1078,17 @@ - (void)invalidateLayer

for (UIView *subview in self.currentContainerView.subviews) {
if ([subview isKindOfClass:[UIImageView class]]) {
RCTCornerInsets cornerInsets = RCTGetCornerInsets(
RCTCornerRadiiFromBorderRadii(borderMetrics.borderRadii),
RCTUIEdgeInsetsFromEdgeInsets(borderMetrics.borderWidths));

// If the subview is an image view, we have to apply the mask directly to the image view's layer,
// otherwise the image might overflow with the border radius.
subview.layer.mask = [self createMaskLayer:subview.bounds cornerInsets:cornerInsets];
// Note(Discord/Hanno): The parent already applies the mask/clipping so this should be unnecessary.
// It has shown to cause CPU spikes + rendering hitches as this starts to cause offscreen draw passes in the render server.
//
// RCTCornerInsets cornerInsets = RCTGetCornerInsets(
// RCTCornerRadiiFromBorderRadii(borderMetrics.borderRadii),
// RCTUIEdgeInsetsFromEdgeInsets(borderMetrics.borderWidths));

// // If the subview is an image view, we have to apply the mask directly to the image view's layer,
// // otherwise the image might overflow with the border radius.
// subview.layer.mask = [self createMaskLayer:subview.bounds cornerInsets:cornerInsets];
subview.layer.mask = nil;
}
}
} else if (
Expand Down
Loading