fix(FirebaseStorageUI): fix SPM build failure with Firebase Storage 11.x#1350
Open
demolaf wants to merge 7 commits into
Open
fix(FirebaseStorageUI): fix SPM build failure with Firebase Storage 11.x#1350demolaf wants to merge 7 commits into
demolaf wants to merge 7 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors header imports in FirebaseStorageUI to resolve Clang module-scanner failures for Swift Package Manager (SPM) builds. It replaces direct @import FirebaseStorage statements in public headers with forward declarations for SPM, moving the actual imports and category declarations to the implementation files. A review comment correctly points out that this change may cause compilation failures in test targets (such as FUIImageViewCategoryTests.m) that rely on these headers, and suggests explicitly importing FirebaseStorage in those test files.
This was referenced Jun 9, 2026
Lyokone
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1271
FirebaseStorage 9+ is pure Swift with no ObjC umbrella headers. Using
@import FirebaseStoragein public headers caused the Clang dependency scanner to fail before compilation even begins.Replace
@importin public headers with@classforward declarations and move the actual imports into.mfiles.