fix(sourcemaps): Prevent Debug ID collisions#3356
Open
szokeasaurusrex wants to merge 3 commits into
Open
Conversation
Contributor
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
### Fixes
- Prevent Debug ID collisions ([#3356](https://github.com/getsentry/sentry-cli/pull/3356))If none of the above apply, you can opt out of this check by adding |
Generate Debug IDs from both the generated JS bytes and the sourcemap bytes when a sourcemap is available. This keeps distinct JS files from sharing a Debug ID when their maps are byte-identical, while preserving existing IDs already present in JS or sourcemaps. Add a regression test for identical empty maps with distinct JS inputs. Update the sourcemaps inject snapshots because the injected Debug IDs and embedded source map payloads now change for every affected case. Fixes #3350 Fixes [CLI-341](https://linear.app/getsentry/issue/CLI-341/sentry-cli-mapping-identical-empty-source-maps-to-same-debug-id)
szokeasaurusrex
force-pushed
the
szokeasaurusrex/fix-empty-sourcemaps
branch
from
a3465c5 to
3f96f9f
Compare
Member
Author
|
@JPeer264 this change is needed to fix #3350, but it also will change all the debug IDs (i.e. the same sourcemap/minified file pair in the previous version will have a different debug ID after this update is released). I am assuming that this is okay, but are you aware of any situation where this could break the product? |
szokeasaurusrex
added a commit
that referenced
this pull request
Jul 6, 2026
Bump pinned GitHub-hosted runner labels to the newest GA images from actions/runner-images. Also switch the OpenSSL bottle tag to tahoe so the x86_64 macOS 26 jobs can fetch bottles correctly. Ref #3356
szokeasaurusrex
added a commit
that referenced
this pull request
Jul 6, 2026
Bump pinned GitHub-hosted runner labels to the newest GA images from actions/runner-images. Use the x86_64 Homebrew command under Rosetta to fetch the Tahoe OpenSSL bottle for the macOS 26 jobs. Ref #3356
loewenheim
approved these changes
Jul 6, 2026
szokeasaurusrex
added a commit
that referenced
this pull request
Jul 6, 2026
Bump pinned GitHub-hosted runner labels to the newest GA images from actions/runner-images. Use the x86_64 Homebrew command under Rosetta to fetch the Tahoe OpenSSL bottle for the macOS 26 jobs. Ref #3356
szokeasaurusrex
added a commit
that referenced
this pull request
Jul 6, 2026
Bump pinned GitHub-hosted runner labels to the newest GA images from actions/runner-images. This updates Windows jobs to windows-2025 and macOS jobs to macos-26 while keeping Ubuntu on 24.04, which is still the newest GA Ubuntu label. Ref #3356
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generate Debug IDs from both the generated JS bytes and the sourcemap bytes when a sourcemap is available. This keeps distinct JS files from sharing a Debug ID when their maps are byte-identical, while preserving existing IDs already present in JS or sourcemaps.
Add a regression test for identical empty maps with distinct JS inputs. Update the sourcemaps inject snapshots because the injected Debug IDs and embedded source map payloads now change for every affected case.
Fixes #3350
Fixes CLI-341