Skip to content

Develop - #6803

Open
Aniket-Manus wants to merge 1 commit into
isaac-sim:developfrom
Aniket-Manus:develop
Open

Develop#6803
Aniket-Manus wants to merge 1 commit into
isaac-sim:developfrom
Aniket-Manus:develop

Conversation

@Aniket-Manus

Copy link
Copy Markdown

Manus Documentation update for isaaclab

@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Jul 30, 2026
@Aniket-Manus
Aniket-Manus marked this pull request as ready for review July 30, 2026 11:44
@Aniket-Manus
Aniket-Manus requested a review from a team July 30, 2026 11:44
.. code-block:: bash

source ~/.cloudxr/run/cloudxr.env
./install/plugins/manus/manus_hand_plugin

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Plugin path uses wrong root

When a user follows this workflow from the IsaacLab checkout, ./install/plugins/manus/manus_hand_plugin resolves relative to IsaacLab instead of the separate IsaacTeleop repository where the executable is installed, causing the command to fail with “No such file or directory” and leaving glove tracking unavailable.

@greptile-apps

greptile-apps Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR updates the Manus teleoperation documentation.

  • Runs environment-profile discovery through the selected Isaac Lab Python environment.
  • Documents launching the native Manus plugin after starting CloudXR.

Confidence Score: 4/5

The documentation should not merge until the Manus launch command establishes the IsaacTeleop build directory or uses an unambiguous executable path.

The documented relative plugin path is resolved from the user's current directory, while the executable is installed under a separate IsaacTeleop checkout, causing the recommended workflow to fail from the IsaacLab workspace.

Files Needing Attention: docs/source/how-to/cloudxr_teleoperation.rst

Important Files Changed

Filename Overview
docs/source/how-to/cloudxr_teleoperation.rst Updates Manus setup commands, but the new plugin launch command assumes an unstated IsaacTeleop working directory.

Reviews (1): Last reviewed commit: "Updated setup documentation to use Manus..." | Re-trigger Greptile

@isaaclab-review-bot isaaclab-review-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isaac Lab Review Bot

Documentation-only update to the CloudXR/Manus guide. The newly added manual plugin-launch workflow is unclear about its relationship to automatic activation and uses a relative executable path without establishing the required working directory.

  • Design and architecture: No source, package, or module architecture is affected.
  • API: No public API symbols, CLI arguments, or configuration contracts are changed.
  • Implementation: The manual Manus plugin step needs clarification and an unambiguous invocation path so users can reliably follow the documented workflow.

Minor fixes needed. Posted 1 actionable finding inline.

Conservative automated review; human maintainers own approval decisions.

#. Start Isaac Lab and click **Start XR**.
#. Start Isaac Lab and click **Start XR**. This auto-launches the CloudXR runtime and
writes its environment file.
#. In a separate terminal, source that environment file and launch the Manus plugin

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Suggestion · Implementation — New step contradicts automatic activation text

The unchanged paragraph just above states the Manus plugin ships in isaacteleop and is "activated automatically when configured in the environment's retargeting pipeline", while the added step requires manually building and launching manus_hand_plugin from a relative ./install/... path in an unspecified working directory. Reconcile the two passages and give an unambiguous path or cd step for the binary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant