Develop - #6803
Conversation
| .. code-block:: bash | ||
|
|
||
| source ~/.cloudxr/run/cloudxr.env | ||
| ./install/plugins/manus/manus_hand_plugin |
There was a problem hiding this comment.
When a user follows this workflow from the IsaacLab checkout, ./install/plugins/manus/manus_hand_plugin resolves relative to IsaacLab instead of the separate IsaacTeleop repository where the executable is installed, causing the command to fail with “No such file or directory” and leaving glove tracking unavailable.
Greptile SummaryThe PR updates the Manus teleoperation documentation.
Confidence Score: 4/5The documentation should not merge until the Manus launch command establishes the IsaacTeleop build directory or uses an unambiguous executable path. The documented relative plugin path is resolved from the user's current directory, while the executable is installed under a separate IsaacTeleop checkout, causing the recommended workflow to fail from the IsaacLab workspace. Files Needing Attention: docs/source/how-to/cloudxr_teleoperation.rst Important Files Changed
Reviews (1): Last reviewed commit: "Updated setup documentation to use Manus..." | Re-trigger Greptile |
There was a problem hiding this comment.
Isaac Lab Review Bot
Documentation-only update to the CloudXR/Manus guide. The newly added manual plugin-launch workflow is unclear about its relationship to automatic activation and uses a relative executable path without establishing the required working directory.
- Design and architecture: No source, package, or module architecture is affected.
- API: No public API symbols, CLI arguments, or configuration contracts are changed.
- Implementation: The manual Manus plugin step needs clarification and an unambiguous invocation path so users can reliably follow the documented workflow.
Minor fixes needed. Posted 1 actionable finding inline.
Conservative automated review; human maintainers own approval decisions.
| #. Start Isaac Lab and click **Start XR**. | ||
| #. Start Isaac Lab and click **Start XR**. This auto-launches the CloudXR runtime and | ||
| writes its environment file. | ||
| #. In a separate terminal, source that environment file and launch the Manus plugin |
There was a problem hiding this comment.
🔵 Suggestion · Implementation — New step contradicts automatic activation text
The unchanged paragraph just above states the Manus plugin ships in isaacteleop and is "activated automatically when configured in the environment's retargeting pipeline", while the added step requires manually building and launching manus_hand_plugin from a relative ./install/... path in an unspecified working directory. Reconcile the two passages and give an unambiguous path or cd step for the binary.
Manus Documentation update for isaaclab