Skip to content

chore: fix visionOS compiler errors#3018

Merged
Saadnajmi merged 3 commits into
microsoft:mainfrom
joannaquu:joannaqu/fix-vision
Jul 13, 2026
Merged

chore: fix visionOS compiler errors#3018
Saadnajmi merged 3 commits into
microsoft:mainfrom
joannaquu:joannaqu/fix-vision

Conversation

@joannaquu

Copy link
Copy Markdown

Summary:

Fixing visionOS build

  • RCTUITextView and RCTUITextField.mm's setDisableKeyboardShortcuts has some code behind an iOS ifdef. This causes the complier to complain that we never set the ivar. Move the ivar.
  • interfaceOrientationDidChange is behind an iOS ifdef. The usage of it should be too

Test Plan:

Local build

@joannaquu joannaquu requested a review from a team as a code owner July 10, 2026 22:41
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

@Saadnajmi

Copy link
Copy Markdown
Collaborator

/backport 0.81-stable

Comment thread packages/react-native/React/CoreModules/RCTDeviceInfo.mm
@microsoft-react-native-sdk

Copy link
Copy Markdown

Backport results

  • ⚠️ 0.81-stable : branch does not exist

@Saadnajmi Saadnajmi changed the title Fix visionOS build fix: visionOS compiler errors Jul 11, 2026
@Saadnajmi

Copy link
Copy Markdown
Collaborator

/backport 0.81-stable

@microsoft-react-native-sdk

Copy link
Copy Markdown

Backport results

  • 0.81-stable: cherry-pick conflicts (manual backport needed)

@Saadnajmi

Copy link
Copy Markdown
Collaborator

@copilot backport to 0.81-stable

@Saadnajmi Saadnajmi changed the title fix: visionOS compiler errors chore: fix visionOS compiler errors Jul 13, 2026
@Saadnajmi Saadnajmi merged commit 1124b81 into microsoft:main Jul 13, 2026
38 checks passed
Saadnajmi added a commit that referenced this pull request Jul 13, 2026
## Summary
Backport of the changes from PR #3018 to `0.81-stable`.

Includes a patch version plan generated with the documented NX release
workflow.

## Test Plan
Same as the original PR.

- `yarn nx release plan:check`

---------

Co-authored-by: Joanna Qu <55368679+joannaquu@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants