Skip to content

chore(ui): account for nested code elements - #9028

Open
avivkeller wants to merge 1 commit into
mainfrom
fix-ui-hydration
Open

chore(ui): account for nested code elements#9028
avivkeller wants to merge 1 commit into
mainfrom
fix-ui-hydration

Conversation

@avivkeller

@avivkeller avivkeller commented Jul 28, 2026

Copy link
Copy Markdown
Member

@avivkeller
avivkeller requested a review from a team as a code owner July 28, 2026 18:28
Copilot AI review requested due to automatic review settings July 28, 2026 18:28
@vercel

vercel Bot commented Jul 28, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nodejs-org Ready Ready Preview Jul 28, 2026 6:29pm

Request Review

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@cursor

cursor Bot commented Jul 28, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Single CSS selector change in a presentational component with no auth, data, or API impact.

Overview
BaseCodeBox styling now targets code anywhere under .content instead of only a direct child of the pre, so typography and line-number layout still apply when something sits between the pre and code (e.g. SSR/hydration or richer markup).

Shipped as a patch for @node-core/ui-components via changeset.

Reviewed by Cursor Bugbot for commit a9304fc. Bugbot is set up for automated code reviews on this repo. Configure here.

@codecov

codecov Bot commented Jul 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.13%. Comparing base (c086c54) to head (a9304fc).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9028      +/-   ##
==========================================
+ Coverage   75.10%   75.13%   +0.03%     
==========================================
  Files         102      102              
  Lines        9109     9109              
  Branches      372      372              
==========================================
+ Hits         6841     6844       +3     
+ Misses       2264     2261       -3     
  Partials        4        4              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit a9304fc. Configure here.

p-4;

& > code {
code {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incomplete nested code selector update

Medium Severity

The PR widens .content code styles to descendants so a wrapper between pre and code still matches, but the no-line-numbers rule still uses a direct-child > code selector. With that wrapper, short blocks keep line-number padding and counters even when no-line-numbers is set.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit a9304fc. Configure here.

@github-actions

Copy link
Copy Markdown
Contributor

📦 Build Size Comparison

Summary

Metric Value
Old Total First Load JS 10.65 MB
New Total First Load JS 10.65 MB
Delta 0 B (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants