Skip to content

chore(ui): account for nested code elements #9028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
avivkeller wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −2
Open

chore(ui): account for nested code elements #9028

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a9304fc
chore(ui): account for nested `code` elements
avivkeller Jul 28, 2026
33f10b7
fixup!
avivkeller Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/ui-hydration-fix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@node-core/ui-components': patch
---

Account for a possible wrapper between a code boxes `pre` and `code`.
4 changes: 2 additions & 2 deletions packages/ui-components/src/Common/BaseCodeBox/index.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
min-w-0
p-4;

& > code {
code {
Comment thread
cursor[bot] marked this conversation as resolved.
@apply font-ibm-plex-mono
font-regular
scrollbar-thin
Expand Down Expand Up @@ -59,7 +59,7 @@
}
}

&[class*='no-line-numbers'] > code > [class='line'] {
&[class*='no-line-numbers'] code > [class='line'] {
@apply pl-0;

&:not(:empty:last-child)::after {
Expand Down
Loading