fix: apply follow-up fixes from review of recent commits on develop - #13695
Draft
Planeshifter wants to merge 3 commits into
Draft
fix: apply follow-up fixes from review of recent commits on develop#13695Planeshifter wants to merge 3 commits into
Planeshifter wants to merge 3 commits into
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YCqgEQhbWHpzMMboqCFg6i
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YCqgEQhbWHpzMMboqCFg6i
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YCqgEQhbWHpzMMboqCFg6i
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up fixes for commits merged to
developbetween 2026-07-26 14:39 PDT (f027a8a) and 2026-07-27 01:40 PDT (02d9b41).This pull request:
blas/ext/base/zcartesian-product: Fixstdlib_strided_zcartesian_product_ndarray's stride buffer type:sawas declaredCBLAS_INT sa[ 2 ](int32 on non-ILP64 builds) but passed tostdlib_ndarray_is_row_major, which expectsint64_t *strides. The callee was reading garbage past the array and could pick the wrong row-/column-major branch, silently corrupting output placement. Changed toint64_t sa[ 2 ], matchingzcartesian-square. Introduced in c19010a; seelib/node_modules/@stdlib/blas/ext/base/zcartesian-product/src/main.c.math/base/special/exp2: Fixtest.native.js(aa63474 — introduces ULP diff testing): five assertion messages read'return expected value'instead of'returns expected value', inconsistent withtest.jsfrom the same commit and the rest of the file. Corrected all five to'returns expected value'inlib/node_modules/@stdlib/math/base/special/exp2/test/test.native.js.number/uint64/parse: Fixes an article typo introduced in 0404059: "an 64-bit unsigned integer" → "a 64-bit unsigned integer" inlib/node_modules/@stdlib/number/uint64/parse/README.md, aligning the Notes section with the phrasing already used elsewhere in the same README and in sibling packages.Related Issues
No.
Questions
No.
Other
Validation. The 24 commits in the window were reviewed by four independent passes: two style-compliance audits comparing new packages against established sibling packages and the guidelines in
docs/style-guides, and two bug scans over the full diff (including the newwxsandarray wrapper family,gwxmy,zcartesian-productC sources,number/uint64/parseparsing logic, and theml/base/sgd-classificationpenalty packages). Only findings that were independently re-verified against the repository were retained. Deliberately excluded: subjective suggestions, style preferences not required by the style guides, and anything requiring changes outside the reviewed diff to validate (e.g., a possibly-unusedEPSrequire inmath/base/special/acscdftests and a pre-existing "Rate parameter." wording in regenerated REPL help data).This PR is a draft for maintainer audit; it intentionally does not close any issues.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code as part of a scheduled automated review of commits merged to
developin the last 24 hours. Claude Code identified the issues, verified them against the repository, and generated the fixes; a maintainer will audit before promoting from draft.Generated by Claude Code