Skip to content

fix: apply follow-up fixes from review of recent commits on develop - #13695

Draft
Planeshifter wants to merge 3 commits into
developfrom
philipp/fix-commit-review-2026-07-27
Draft

fix: apply follow-up fixes from review of recent commits on develop#13695
Planeshifter wants to merge 3 commits into
developfrom
philipp/fix-commit-review-2026-07-27

Conversation

@Planeshifter

Copy link
Copy Markdown
Member

Description

What is the purpose of this pull request?

Follow-up fixes for commits merged to develop between 2026-07-26 14:39 PDT (f027a8a) and 2026-07-27 01:40 PDT (02d9b41).

This pull request:

  • blas/ext/base/zcartesian-product: Fix stdlib_strided_zcartesian_product_ndarray's stride buffer type: sa was declared CBLAS_INT sa[ 2 ] (int32 on non-ILP64 builds) but passed to stdlib_ndarray_is_row_major, which expects int64_t *strides. The callee was reading garbage past the array and could pick the wrong row-/column-major branch, silently corrupting output placement. Changed to int64_t sa[ 2 ], matching zcartesian-square. Introduced in c19010a; see lib/node_modules/@stdlib/blas/ext/base/zcartesian-product/src/main.c.
  • math/base/special/exp2: Fix test.native.js (aa63474 — introduces ULP diff testing): five assertion messages read 'return expected value' instead of 'returns expected value', inconsistent with test.js from the same commit and the rest of the file. Corrected all five to 'returns expected value' in lib/node_modules/@stdlib/math/base/special/exp2/test/test.native.js.
  • number/uint64/parse: Fixes an article typo introduced in 0404059: "an 64-bit unsigned integer" → "a 64-bit unsigned integer" in lib/node_modules/@stdlib/number/uint64/parse/README.md, aligning the Notes section with the phrasing already used elsewhere in the same README and in sibling packages.

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Validation. The 24 commits in the window were reviewed by four independent passes: two style-compliance audits comparing new packages against established sibling packages and the guidelines in docs/style-guides, and two bug scans over the full diff (including the new wxsa ndarray wrapper family, gwxmy, zcartesian-product C sources, number/uint64/parse parsing logic, and the ml/base/sgd-classification penalty packages). Only findings that were independently re-verified against the repository were retained. Deliberately excluded: subjective suggestions, style preferences not required by the style guides, and anything requiring changes outside the reviewed diff to validate (e.g., a possibly-unused EPS require in math/base/special/acscdf tests and a pre-existing "Rate parameter." wording in regenerated REPL help data).

This PR is a draft for maintainer audit; it intentionally does not close any issues.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

This PR was authored by Claude Code as part of a scheduled automated review of commits merged to develop in the last 24 hours. Claude Code identified the issues, verified them against the repository, and generated the fixes; a maintainer will audit before promoting from draft.



Generated by Claude Code

@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base/zcartesian-product $\\color{green}542/542$
$\\color{green}+100.00\\%$
$\\color{green}40/40$
$\\color{green}+100.00\\%$
$\\color{green}4/4$
$\\color{green}+100.00\\%$
$\\color{green}542/542$
$\\color{green}+100.00\\%$
math/base/special/exp2 $\\color{green}327/327$
$\\color{green}+100.00\\%$
$\\color{green}19/19$
$\\color{green}+100.00\\%$
$\\color{green}4/4$
$\\color{green}+100.00\\%$
$\\color{green}327/327$
$\\color{green}+100.00\\%$
number/uint64/parse $\\color{red}213/215$
$\\color{green}+99.07\\%$
$\\color{red}32/33$
$\\color{green}+96.97\\%$
$\\color{green}2/2$
$\\color{green}+100.00\\%$
$\\color{red}213/215$
$\\color{green}+99.07\\%$

The above coverage report was generated for the changes in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants