Skip to content

chore: clean-up #13695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kgryte merged 4 commits into from
Jul 27, 2026
+8 −7
Merged

chore: clean-up #13695

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
638cc56
fix: use correct stride array type in `blas/ext/base/zcartesian-product`
claude Jul 27, 2026
5ff5fa8
test: fix assertion messages in `math/base/special/exp2`
claude Jul 27, 2026
f2de1fe
docs: fix grammar in `number/uint64/parse`
claude Jul 27, 2026
03bda4e
Apply suggestions from code review
kgryte Jul 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/node_modules/@stdlib/blas/ext/base/zcartesian-product/src/main.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
#include "stdlib/blas/base/shared.h"
#include "stdlib/strided/base/stride2offset.h"
#include "stdlib/complex/float64/ctor.h"
#include <stdint.h>

/**
* Computes the Cartesian product for two double-precision complex floating-point strided arrays.
Expand Down Expand Up @@ -80,7 +81,7 @@ void API_SUFFIX(stdlib_strided_zcartesian_product)( const CBLAS_LAYOUT order, co
* @param offsetOut starting index for Out
*/
void API_SUFFIX(stdlib_strided_zcartesian_product_ndarray)( const CBLAS_INT M, const CBLAS_INT N, const stdlib_complex128_t *X, const CBLAS_INT strideX, const CBLAS_INT offsetX, const stdlib_complex128_t *Y, const CBLAS_INT strideY, const CBLAS_INT offsetY, stdlib_complex128_t *Out, const CBLAS_INT strideOut1, const CBLAS_INT strideOut2, const CBLAS_INT offsetOut ) {
CBLAS_INT sa[ 2 ];
int64_t sa[ 2 ];
CBLAS_INT iy;
CBLAS_INT ix;
CBLAS_INT io;
Expand Down
10 changes: 5 additions & 5 deletions lib/node_modules/@stdlib/math/base/special/exp2/test/test.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ tape( 'the function accurately computes `2**x` for negative medium numbers', opt

for ( i = 0; i < x.length; i++ ) {
v = exp2( x[ i ] );
t.strictEqual( isAlmostSameValue( v, expected[ i ], 1 ), true, 'return expected value' );
t.strictEqual( isAlmostSameValue( v, expected[ i ], 1 ), true, 'returns expected value' );
}
t.end();
});
Expand All @@ -82,7 +82,7 @@ tape( 'the function accurately computes `2**x` for positive medium numbers', opt

for ( i = 0; i < x.length; i++ ) {
v = exp2( x[ i ] );
t.strictEqual( isAlmostSameValue( v, expected[ i ], 1 ), true, 'return expected value' );
t.strictEqual( isAlmostSameValue( v, expected[ i ], 1 ), true, 'returns expected value' );
}
t.end();
});
Expand All @@ -98,7 +98,7 @@ tape( 'the function accurately computes `2**x` for negative small numbers', opts

for ( i = 0; i < x.length; i++ ) {
v = exp2( x[ i ] );
t.strictEqual( isAlmostSameValue( v, expected[ i ], 1 ), true, 'return expected value' );
t.strictEqual( isAlmostSameValue( v, expected[ i ], 1 ), true, 'returns expected value' );
}
t.end();
});
Expand All @@ -114,7 +114,7 @@ tape( 'the function accurately computes `2**x` for positive small numbers', opts

for ( i = 0; i < x.length; i++ ) {
v = exp2( x[ i ] );
t.strictEqual( isAlmostSameValue( v, expected[ i ], 1 ), true, 'return expected value' );
t.strictEqual( isAlmostSameValue( v, expected[ i ], 1 ), true, 'returns expected value' );
}
t.end();
});
Expand All @@ -130,7 +130,7 @@ tape( 'the function accurately computes `2**x` for very small `x`', opts, functi

for ( i = 0; i < x.length; i++ ) {
v = exp2( x[ i ] );
t.strictEqual( isAlmostSameValue( v, expected[ i ], 1 ), true, 'return expected value' );
t.strictEqual( isAlmostSameValue( v, expected[ i ], 1 ), true, 'returns expected value' );
}
t.end();
});
Expand Down
2 changes: 1 addition & 1 deletion lib/node_modules/@stdlib/number/uint64/parse/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ a = parseUint64( '123abcxyz', 36 );

## Notes

- The input string must be a valid representation of an 64-bit unsigned integer.
- The input string must be a valid representation of a 64-bit unsigned integer.
- If the provided string is malformed (e.g., contains invalid characters or is incomplete), the function throws a `SyntaxError`.
- If the provided string represents a value greater than `2^64-1` or the radix is not an integer on the interval `[2, 36]`, the function throws a `RangeError`.

Expand Down