Skip to content

Multi robot sim fixes#924

Closed
ayin21 wants to merge 10 commits into
mainfrom
feature/multi_robot_sim_fixes
Closed

Multi robot sim fixes#924
ayin21 wants to merge 10 commits into
mainfrom
feature/multi_robot_sim_fixes

Conversation

@ayin21

@ayin21 ayin21 commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

A loose set of fixes that enables multi robot sim operations (very basic). For full team behavior testing a lot of things are still missing. For example the team communication does not work with multiple instances on the same machine.

Checklist

  • Run pixi run build
  • Write documentation
  • Test on your machine
  • Test on the robot
  • Create issues for future work
  • Triage this PR and label it

@texhnolyze texhnolyze left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be combined with:

  • #882 (changes in teamcomm threading)
  • #913 (changes in teamcomm UDP Broadcast address selection)

@Flova @jaagut in which order do we want to do this?
My suggestion would be to either merge this or the automatic broadcast address selection first and then the TUI PR first as it does not majorly have to do with teamcomm.

Comment thread src/bitbots_simulation/bitbots_mujoco_sim/xml/pi_plus.xml
# (domain_bridge's bidirectional mode guards against the bridge looping on itself).
config["topics"]["team_comm_binary_transport"] = {
"type": "std_msgs/msg/UInt8MultiArray",
"bidirectional": True,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested if two robots received each other's messages?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a game with working team comm, but weirdly the current state here seems to be outdated. I need to check my PC if something was not pushed when I am back home.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you found something @Flova

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't on the PC since then

@Flova

Flova commented Jun 21, 2026

Copy link
Copy Markdown
Member

I would merge the TUI last as it has some TODOs still and is low prio. This here also has some todos left as for example currently all robots have the same player number, leading to the team com being dropped, so we need a non file based way to inject this. So the auto wifi one should go first imo..

jaagut added 2 commits June 24, 2026 17:54
…im_fixes

# Conflicts:
#	src/bitbots_team_communication/bitbots_team_communication/bitbots_team_communication/communication.py
#	src/bitbots_team_communication/bitbots_team_communication/config/team_communication_config.yaml
@jaagut jaagut moved this from 🆕 New to 👀 In review in Software Jun 24, 2026

@MegaIng MegaIng left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have an alterntive branch, I am going to open a PR later

@github-project-automation github-project-automation Bot moved this from 👀 In review to 🏗 In progress in Software Jun 30, 2026
@MegaIng MegaIng closed this Jul 2, 2026
@github-project-automation github-project-automation Bot moved this from 🏗 In progress to ✅ Done in Software Jul 2, 2026
@Flova Flova deleted the feature/multi_robot_sim_fixes branch July 2, 2026 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

5 participants