Skip to content

[Tophat] Add Bitrise client for Tophat artifact discovery#419

Merged
kieran-osgood-shopify merged 10 commits into
mainfrom
kieran-osgood/07-08-addbitriseclientfortophatartifactdiscovery
Jul 16, 2026
Merged

[Tophat] Add Bitrise client for Tophat artifact discovery#419
kieran-osgood-shopify merged 10 commits into
mainfrom
kieran-osgood/07-08-addbitriseclientfortophatartifactdiscovery

Conversation

@kieran-osgood-shopify

@kieran-osgood-shopify kieran-osgood-shopify commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

What changes are you making?

In #401 the UX for a first-time user would be

  1. prompt you to open the bit rise to create a pat
  2. then you have to go go over to the top menu bar app, Open the settings, extensions, bitrise, then paste the token
  3. return to the terminal and press enter

This required multiple app hops and I wanted to unify this down a bit so now the developer experience is going to be:

  1. the CLI will take you to you create the PAT, that bit stays the same
  2. Return to the terminal, enter the token into the password protected prompt
  3. Press enter

In this case the token is stored into keychain and gets pushed into the keychain entry for top hat, authorizing top hat to access it. This means the user no longer has to open top hat settings in order to set up a token and streamline the process a bit. they just have to sign in on a permission prompt

How to test

Delete the bitrise token in tophat - then run dev tophat and confirm that it launches bitrise to create a pat, and after pasting it in and pressing enter you receive a permission prompt for tophat, after that the app should install

image.png


Before you merge

Important

  • I've added tests to support my implementation
  • I have read and agree with the Contribution Guidelines
  • I have read and agree with the Code of Conduct
  • I've updated the relevant platform README (platforms/swift/README.md and/or platforms/android/README.md)

Releasing a new Swift version?
  • I have bumped the version in ShopifyCheckoutKit.podspec
  • I have bumped the version in platforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swift
  • I have updated the SwiftPM/CocoaPods version snippets in platforms/swift/README.md (major version only)
Releasing a new Embedded Checkout Protocol version?
  • I have bumped embeddedCheckoutProtocolAndroid in platforms/android/gradle/libs.versions.toml
  • I have updated protocol/languages/kotlin/embedded-checkout-protocol/api/embedded-checkout-protocol.api if the public API changed
Releasing a new Android version?
  • I have bumped checkoutKitAndroid in platforms/android/gradle/libs.versions.toml
  • I have updated the Gradle/Maven version snippets in platforms/android/README.md

Tip

See the Contributing documentation for the full release process per platform.

@github-actions github-actions Bot added the #gsd:50662 Rebase Checkout Kit on UCP label Jul 8, 2026
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/07-03-addtophatintegrationforcheckoutkitreactnativebuilds branch from 592f5f4 to b12780f Compare July 9, 2026 09:34
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/07-08-addbitriseclientfortophatartifactdiscovery branch from f0b9a8f to 97464ef Compare July 9, 2026 09:34
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/07-03-addtophatintegrationforcheckoutkitreactnativebuilds branch from b12780f to bc818ae Compare July 9, 2026 12:25
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/07-08-addbitriseclientfortophatartifactdiscovery branch from 97464ef to eb98c76 Compare July 9, 2026 12:25
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/07-03-addtophatintegrationforcheckoutkitreactnativebuilds branch from bc818ae to 3f0ae1c Compare July 9, 2026 12:59
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/07-08-addbitriseclientfortophatartifactdiscovery branch from eb98c76 to 17aa527 Compare July 9, 2026 12:59
@kieran-osgood-shopify kieran-osgood-shopify changed the title Add Bitrise client for Tophat artifact discovery [Tophat] Add Bitrise client for Tophat artifact discovery Jul 10, 2026
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/07-08-addbitriseclientfortophatartifactdiscovery branch from 17aa527 to c32b0f5 Compare July 10, 2026 11:05
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/07-03-addtophatintegrationforcheckoutkitreactnativebuilds branch from 3f0ae1c to 5aab839 Compare July 10, 2026 11:05
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/07-08-addbitriseclientfortophatartifactdiscovery branch from c32b0f5 to 9d98b2e Compare July 10, 2026 11:11
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/07-03-addtophatintegrationforcheckoutkitreactnativebuilds branch 2 times, most recently from 0d2605d to 96fe2c9 Compare July 10, 2026 17:02
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/07-08-addbitriseclientfortophatartifactdiscovery branch from 9d98b2e to 81d2278 Compare July 10, 2026 17:02
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/07-03-addtophatintegrationforcheckoutkitreactnativebuilds branch from 96fe2c9 to 81cbc42 Compare July 13, 2026 12:05
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/07-08-addbitriseclientfortophatartifactdiscovery branch 2 times, most recently from 632f7df to e70cf1d Compare July 13, 2026 13:30
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/07-03-addtophatintegrationforcheckoutkitreactnativebuilds branch from 81cbc42 to 7a02177 Compare July 13, 2026 13:30
@kieran-osgood-shopify
kieran-osgood-shopify changed the base branch from kieran-osgood/07-03-addtophatintegrationforcheckoutkitreactnativebuilds to graphite-base/419 July 13, 2026 13:36
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/07-08-addbitriseclientfortophatartifactdiscovery branch from e70cf1d to 63f15ed Compare July 13, 2026 14:54
@kieran-osgood-shopify
kieran-osgood-shopify changed the base branch from graphite-base/419 to kieran-osgood/07-03-addtophatintegrationforcheckoutkitreactnativebuilds July 13, 2026 14:54
@kieran-osgood-shopify
kieran-osgood-shopify changed the base branch from kieran-osgood/07-03-addtophatintegrationforcheckoutkitreactnativebuilds to graphite-base/419 July 13, 2026 15:06
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/07-08-addbitriseclientfortophatartifactdiscovery branch from 63f15ed to 400326a Compare July 15, 2026 10:59
@graphite-app
graphite-app Bot changed the base branch from graphite-base/419 to kieran-osgood/07-03-addtophatintegrationforcheckoutkitreactnativebuilds July 15, 2026 10:59
require "json"
require "uri"
require_relative "json_http_client"
require_relative "../../scripts/lib/json_http_client"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved this to a shared scripts/lib to be reused by the tophat bitrise client

@kieran-osgood-shopify
kieran-osgood-shopify marked this pull request as ready for review July 15, 2026 16:17
@kieran-osgood-shopify
kieran-osgood-shopify requested a review from a team as a code owner July 15, 2026 16:17
@bitrise

bitrise Bot commented Jul 15, 2026

Copy link
Copy Markdown

Install this build

Open Tophat, select your target device, then click Install. Links open on the Mac running Tophat.

SDK Install
React Native Install with Tophat

Checkout Kit E2E results

Status Suite Target Platform OS version tag Device
tests/shared/launch-smoke.yaml react-native ios latest iPhone 15
iOS 27 Beta
tests/shared/launch-smoke.yaml react-native android latest Google Pixel 10
Android 16.0
tests/shared/launch-smoke.yaml kotlin android latest Google Pixel 10
Android 16.0
tests/shared/launch-smoke.yaml swift ios latest iPhone 15
iOS 27 Beta

@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/07-03-addtophatintegrationforcheckoutkitreactnativebuilds branch from dacf0df to a068760 Compare July 15, 2026 16:43
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/07-08-addbitriseclientfortophatartifactdiscovery branch from 41b6dcb to 8fe20b8 Compare July 15, 2026 16:43
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/07-03-addtophatintegrationforcheckoutkitreactnativebuilds branch from a068760 to c748d05 Compare July 15, 2026 17:07
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/07-08-addbitriseclientfortophatartifactdiscovery branch from 8fe20b8 to 72d379e Compare July 15, 2026 17:07
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/07-03-addtophatintegrationforcheckoutkitreactnativebuilds branch from c748d05 to 02e84f2 Compare July 16, 2026 13:41
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/07-08-addbitriseclientfortophatartifactdiscovery branch from 72d379e to 683d892 Compare July 16, 2026 13:41

kieran-osgood-shopify commented Jul 16, 2026

Copy link
Copy Markdown
Contributor Author

Merge activity

  • Jul 16, 4:48 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jul 16, 4:50 PM UTC: Graphite rebased this pull request as part of a merge.
  • Jul 16, 4:50 PM UTC: @kieran-osgood-shopify merged this pull request with Graphite.

@kieran-osgood-shopify
kieran-osgood-shopify changed the base branch from kieran-osgood/07-03-addtophatintegrationforcheckoutkitreactnativebuilds to graphite-base/419 July 16, 2026 16:49
@kieran-osgood-shopify
kieran-osgood-shopify changed the base branch from graphite-base/419 to main July 16, 2026 16:49
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/07-08-addbitriseclientfortophatartifactdiscovery branch from 683d892 to 8ad745c Compare July 16, 2026 16:49
@kieran-osgood-shopify
kieran-osgood-shopify merged commit 49b565f into main Jul 16, 2026
27 of 28 checks passed
@kieran-osgood-shopify
kieran-osgood-shopify deleted the kieran-osgood/07-08-addbitriseclientfortophatartifactdiscovery branch July 16, 2026 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

#gsd:50662 Rebase Checkout Kit on UCP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants