Skip to content

[Tophat] Adds swift/kotlin to tophat install rows#473

Merged
kieran-osgood-shopify merged 1 commit into
mainfrom
kieran-osgood/07-15-feataddswiftkotlintophatinstallrows
Jul 16, 2026
Merged

[Tophat] Adds swift/kotlin to tophat install rows#473
kieran-osgood-shopify merged 1 commit into
mainfrom
kieran-osgood/07-15-feataddswiftkotlintophatinstallrows

Conversation

@kieran-osgood-shopify

@kieran-osgood-shopify kieran-osgood-shopify commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

What changes are you making?

This PR adds Swift / Kotlin tophat install inks and configuration, allowing testing of Swift / Kotlin samples directly from the PR or via dev tophat

image.png

Testing

You don't even have to wait for bitrise to complete, here react native and android haven't finished, but I'm able to run dev tophat 473 and install the Swift build after 1 minute

image.png

There will be 4 options in dev tophat now too
image.png

Before you merge

Important

  • I've added tests to support my implementation
  • I have read and agree with the Contribution Guidelines
  • I have read and agree with the Code of Conduct
  • I've updated the relevant platform README (platforms/swift/README.md and/or platforms/android/README.md)

Releasing a new Swift version?
  • I have bumped the version in ShopifyCheckoutKit.podspec
  • I have bumped the version in platforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swift
  • I have updated the SwiftPM/CocoaPods version snippets in platforms/swift/README.md (major version only)
Releasing a new Embedded Checkout Protocol version?
  • I have bumped embeddedCheckoutProtocolAndroid in platforms/android/gradle/libs.versions.toml
  • I have updated protocol/languages/kotlin/embedded-checkout-protocol/api/embedded-checkout-protocol.api if the public API changed
Releasing a new Android version?
  • I have bumped checkoutKitAndroid in platforms/android/gradle/libs.versions.toml
  • I have updated the Gradle/Maven version snippets in platforms/android/README.md

Tip

See the Contributing documentation for the full release process per platform.

@kieran-osgood-shopify
kieran-osgood-shopify marked this pull request as ready for review July 15, 2026 18:29
@kieran-osgood-shopify
kieran-osgood-shopify requested a review from a team as a code owner July 15, 2026 18:29
@bitrise

bitrise Bot commented Jul 15, 2026

Copy link
Copy Markdown

Install this build

Open Tophat, select your target device, then click Install. Links open on the Mac running Tophat.

SDK Install
React Native Install with Tophat
Swift Install with Tophat
Kotlin Install with Tophat

Checkout Kit E2E results

Status Suite Target Platform OS version tag Device
tests/shared/launch-smoke.yaml react-native ios latest iPhone 15
iOS 27 Beta
tests/shared/launch-smoke.yaml react-native android latest Google Pixel 9
Android 17.0
tests/shared/launch-smoke.yaml kotlin android latest Google Pixel 9
Android 17.0
tests/shared/launch-smoke.yaml swift ios latest iPhone 15
iOS 27 Beta

Copy link
Copy Markdown
Contributor

This is great! Tested locally using the links above and the dev tophat command for each platform and everything seems to work from what I can tell 🎉

@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/07-15-feataddswiftkotlintophatinstallrows branch 2 times, most recently from 9423892 to d0ee006 Compare July 16, 2026 13:41
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/07-10-feataddtheabilitytowaitforabuildtocomplete branch from ea40773 to 68e84aa Compare July 16, 2026 13:41
@github-actions

github-actions Bot commented Jul 16, 2026

Copy link
Copy Markdown

React Native — Coverage Report

Lines Statements Branches Functions
Coverage: 92%
91.85% (327/356) 87.98% (183/208) 100% (86/86)

@github-actions

github-actions Bot commented Jul 16, 2026

Copy link
Copy Markdown

Package Size

Platform Artifact Base Head Delta
Android release AAR 240.3 KiB 240.3 KiB 0 B
Android file breakdown
File Base Head Delta
classes.jar 254.5 KiB 254.5 KiB 0 B
res/layout/checkout_view_content.xml 2.2 KiB 2.2 KiB 0 B
res/layout/checkout_sheet_content.xml 2.0 KiB 2.0 KiB 0 B
res/values/values.xml 1.2 KiB 1.2 KiB 0 B
R.txt 1.1 KiB 1.1 KiB 0 B
proguard.txt 798 B 798 B 0 B
AndroidManifest.xml 578 B 578 B 0 B
res/drawable/close.xml 431 B 431 B 0 B
res/menu/checkout_menu.xml 354 B 354 B 0 B
META-INF/com/android/build/gradle/aar-metadata.properties 157 B 157 B 0 B

Measured from the PR base SHA and PR head SHA. The file breakdown shows uncompressed sizes within each package artifact, so individual files do not sum to the compressed artifact total. This comment reports package artifact sizes only; it is not a final app binary-size report.

kieran-osgood-shopify commented Jul 16, 2026

Copy link
Copy Markdown
Contributor Author

Merge activity

  • Jul 16, 4:48 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jul 16, 4:56 PM UTC: Graphite rebased this pull request as part of a merge.
  • Jul 16, 5:07 PM UTC: @kieran-osgood-shopify merged this pull request with Graphite.

@kieran-osgood-shopify
kieran-osgood-shopify changed the base branch from kieran-osgood/07-10-feataddtheabilitytowaitforabuildtocomplete to graphite-base/473 July 16, 2026 16:53
@kieran-osgood-shopify
kieran-osgood-shopify changed the base branch from graphite-base/473 to main July 16, 2026 16:54
@kieran-osgood-shopify kieran-osgood-shopify changed the title Adds swift/kotlin to tophat install rows [Tophat] Adds swift/kotlin to tophat install rows Jul 16, 2026
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/07-15-feataddswiftkotlintophatinstallrows branch from d0ee006 to f2efb41 Compare July 16, 2026 16:55
@kieran-osgood-shopify
kieran-osgood-shopify merged commit 25c1378 into main Jul 16, 2026
35 checks passed
@kieran-osgood-shopify
kieran-osgood-shopify deleted the kieran-osgood/07-15-feataddswiftkotlintophatinstallrows branch July 16, 2026 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

#gsd:50662 Rebase Checkout Kit on UCP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants