[Tophat] Refactor: extract shared browserstack client#433
Merged
kieran-osgood-shopify merged 1 commit intoJul 16, 2026
Conversation
11 tasks
11 tasks
Contributor
Author
11 tasks
kieran-osgood-shopify
force-pushed
the
kieran-osgood/07-08-addbitriseclientfortophatartifactdiscovery
branch
from
July 10, 2026 11:11
c32b0f5 to
9d98b2e
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/07-10-refactorextractsharedbrowserstackclientandreusehttpclient
branch
from
July 10, 2026 11:11
522efa6 to
a6b3b1f
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/07-08-addbitriseclientfortophatartifactdiscovery
branch
from
July 10, 2026 17:02
9d98b2e to
81d2278
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/07-10-refactorextractsharedbrowserstackclientandreusehttpclient
branch
2 times, most recently
from
July 13, 2026 12:05
4653cdd to
aba303d
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/07-08-addbitriseclientfortophatartifactdiscovery
branch
2 times, most recently
from
July 13, 2026 13:30
632f7df to
e70cf1d
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/07-10-refactorextractsharedbrowserstackclientandreusehttpclient
branch
from
July 13, 2026 13:30
aba303d to
0a3c789
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/07-08-addbitriseclientfortophatartifactdiscovery
branch
from
July 13, 2026 14:54
e70cf1d to
63f15ed
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/07-10-refactorextractsharedbrowserstackclientandreusehttpclient
branch
from
July 13, 2026 14:54
0a3c789 to
089eeaf
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/07-08-addbitriseclientfortophatartifactdiscovery
branch
2 times, most recently
from
July 15, 2026 10:59
400326a to
95d8eca
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/07-10-refactorextractsharedbrowserstackclientandreusehttpclient
branch
2 times, most recently
from
July 15, 2026 16:14
52e5fb5 to
0214bcf
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/07-08-addbitriseclientfortophatartifactdiscovery
branch
from
July 15, 2026 16:14
95d8eca to
41b6dcb
Compare
kieran-osgood-shopify
marked this pull request as ready for review
July 15, 2026 16:18
Install this buildOpen Tophat, select your target device, then click Install. Links open on the Mac running Tophat.
Checkout Kit E2E results
|
kieran-osgood-shopify
force-pushed
the
kieran-osgood/07-10-refactorextractsharedbrowserstackclientandreusehttpclient
branch
from
July 15, 2026 16:43
0214bcf to
3cd457e
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/07-08-addbitriseclientfortophatartifactdiscovery
branch
from
July 15, 2026 16:43
41b6dcb to
8fe20b8
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/07-08-addbitriseclientfortophatartifactdiscovery
branch
from
July 15, 2026 17:07
8fe20b8 to
72d379e
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/07-10-refactorextractsharedbrowserstackclientandreusehttpclient
branch
from
July 15, 2026 17:07
3cd457e to
820a2d7
Compare
11 tasks
kyle-schellen
approved these changes
Jul 15, 2026
markmur
approved these changes
Jul 16, 2026
kieran-osgood-shopify
force-pushed
the
kieran-osgood/07-10-refactorextractsharedbrowserstackclientandreusehttpclient
branch
from
July 16, 2026 13:41
820a2d7 to
77d01c6
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/07-08-addbitriseclientfortophatartifactdiscovery
branch
from
July 16, 2026 13:41
72d379e to
683d892
Compare
This was referenced Jul 16, 2026
Contributor
Author
Merge activity
|
kieran-osgood-shopify
changed the base branch from
kieran-osgood/07-08-addbitriseclientfortophatartifactdiscovery
to
graphite-base/433
July 16, 2026 16:49
kieran-osgood-shopify
force-pushed
the
kieran-osgood/07-10-refactorextractsharedbrowserstackclientandreusehttpclient
branch
from
July 16, 2026 16:51
77d01c6 to
06412de
Compare
kieran-osgood-shopify
deleted the
kieran-osgood/07-10-refactorextractsharedbrowserstackclientandreusehttpclient
branch
July 16, 2026 16:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What changes are you making?
Small refactor to extract a browserstack client instead of nesting the http calls in the execute browserstack run script
How to test
Before you merge
Important
platforms/swift/README.mdand/orplatforms/android/README.md)Releasing a new Swift version?
ShopifyCheckoutKit.podspecplatforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swiftplatforms/swift/README.md(major version only)Releasing a new Embedded Checkout Protocol version?
embeddedCheckoutProtocolAndroidinplatforms/android/gradle/libs.versions.tomlprotocol/languages/kotlin/embedded-checkout-protocol/api/embedded-checkout-protocol.apiif the public API changedReleasing a new Android version?
checkoutKitAndroidinplatforms/android/gradle/libs.versions.tomlplatforms/android/README.mdTip
See the Contributing documentation for the full release process per platform.