Skip to content

[Tophat] Refactor: extract shared browserstack client#433

Merged
kieran-osgood-shopify merged 1 commit into
mainfrom
kieran-osgood/07-10-refactorextractsharedbrowserstackclientandreusehttpclient
Jul 16, 2026
Merged

[Tophat] Refactor: extract shared browserstack client#433
kieran-osgood-shopify merged 1 commit into
mainfrom
kieran-osgood/07-10-refactorextractsharedbrowserstackclientandreusehttpclient

Conversation

@kieran-osgood-shopify

@kieran-osgood-shopify kieran-osgood-shopify commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

What changes are you making?

Small refactor to extract a browserstack client instead of nesting the http calls in the execute browserstack run script

How to test


Before you merge

Important

  • I've added tests to support my implementation
  • I have read and agree with the Contribution Guidelines
  • I have read and agree with the Code of Conduct
  • I've updated the relevant platform README (platforms/swift/README.md and/or platforms/android/README.md)

Releasing a new Swift version?
  • I have bumped the version in ShopifyCheckoutKit.podspec
  • I have bumped the version in platforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swift
  • I have updated the SwiftPM/CocoaPods version snippets in platforms/swift/README.md (major version only)
Releasing a new Embedded Checkout Protocol version?
  • I have bumped embeddedCheckoutProtocolAndroid in platforms/android/gradle/libs.versions.toml
  • I have updated protocol/languages/kotlin/embedded-checkout-protocol/api/embedded-checkout-protocol.api if the public API changed
Releasing a new Android version?
  • I have bumped checkoutKitAndroid in platforms/android/gradle/libs.versions.toml
  • I have updated the Gradle/Maven version snippets in platforms/android/README.md

Tip

See the Contributing documentation for the full release process per platform.

@kieran-osgood-shopify kieran-osgood-shopify changed the title refactor: extract shared browserstack client and reuse http client [Tophat] refactor: extract shared browserstack client and reuse http client Jul 10, 2026
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/07-08-addbitriseclientfortophatartifactdiscovery branch from c32b0f5 to 9d98b2e Compare July 10, 2026 11:11
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/07-10-refactorextractsharedbrowserstackclientandreusehttpclient branch from 522efa6 to a6b3b1f Compare July 10, 2026 11:11
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/07-08-addbitriseclientfortophatartifactdiscovery branch from 9d98b2e to 81d2278 Compare July 10, 2026 17:02
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/07-10-refactorextractsharedbrowserstackclientandreusehttpclient branch 2 times, most recently from 4653cdd to aba303d Compare July 13, 2026 12:05
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/07-08-addbitriseclientfortophatartifactdiscovery branch 2 times, most recently from 632f7df to e70cf1d Compare July 13, 2026 13:30
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/07-10-refactorextractsharedbrowserstackclientandreusehttpclient branch from aba303d to 0a3c789 Compare July 13, 2026 13:30
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/07-08-addbitriseclientfortophatartifactdiscovery branch from e70cf1d to 63f15ed Compare July 13, 2026 14:54
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/07-10-refactorextractsharedbrowserstackclientandreusehttpclient branch from 0a3c789 to 089eeaf Compare July 13, 2026 14:54
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/07-08-addbitriseclientfortophatartifactdiscovery branch 2 times, most recently from 400326a to 95d8eca Compare July 15, 2026 10:59
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/07-10-refactorextractsharedbrowserstackclientandreusehttpclient branch 2 times, most recently from 52e5fb5 to 0214bcf Compare July 15, 2026 16:14
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/07-08-addbitriseclientfortophatartifactdiscovery branch from 95d8eca to 41b6dcb Compare July 15, 2026 16:14
@kieran-osgood-shopify kieran-osgood-shopify changed the title [Tophat] refactor: extract shared browserstack client and reuse http client [Tophat] refactor: extract shared browserstack client Jul 15, 2026
@kieran-osgood-shopify
kieran-osgood-shopify marked this pull request as ready for review July 15, 2026 16:18
@kieran-osgood-shopify
kieran-osgood-shopify requested a review from a team as a code owner July 15, 2026 16:18
@bitrise

bitrise Bot commented Jul 15, 2026

Copy link
Copy Markdown

Install this build

Open Tophat, select your target device, then click Install. Links open on the Mac running Tophat.

SDK Install
React Native Install with Tophat

Checkout Kit E2E results

Status Suite Target Platform OS version tag Device
tests/shared/launch-smoke.yaml react-native ios latest iPhone 15
iOS 27 Beta
tests/shared/launch-smoke.yaml react-native android latest Google Pixel 9
Android 17.0
tests/shared/launch-smoke.yaml kotlin android latest Google Pixel 9
Android 17.0
tests/shared/launch-smoke.yaml swift ios latest iPhone 15
iOS 27 Beta

@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/07-10-refactorextractsharedbrowserstackclientandreusehttpclient branch from 0214bcf to 3cd457e Compare July 15, 2026 16:43
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/07-08-addbitriseclientfortophatartifactdiscovery branch from 41b6dcb to 8fe20b8 Compare July 15, 2026 16:43
@kieran-osgood-shopify kieran-osgood-shopify changed the title [Tophat] refactor: extract shared browserstack client [Tophat] Refactor: extract shared browserstack client Jul 15, 2026
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/07-08-addbitriseclientfortophatartifactdiscovery branch from 8fe20b8 to 72d379e Compare July 15, 2026 17:07
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/07-10-refactorextractsharedbrowserstackclientandreusehttpclient branch from 3cd457e to 820a2d7 Compare July 15, 2026 17:07
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/07-10-refactorextractsharedbrowserstackclientandreusehttpclient branch from 820a2d7 to 77d01c6 Compare July 16, 2026 13:41
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/07-08-addbitriseclientfortophatartifactdiscovery branch from 72d379e to 683d892 Compare July 16, 2026 13:41

kieran-osgood-shopify commented Jul 16, 2026

Copy link
Copy Markdown
Contributor Author

Merge activity

  • Jul 16, 4:48 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jul 16, 4:52 PM UTC: Graphite rebased this pull request as part of a merge.
  • Jul 16, 4:52 PM UTC: @kieran-osgood-shopify merged this pull request with Graphite.

@kieran-osgood-shopify
kieran-osgood-shopify changed the base branch from kieran-osgood/07-08-addbitriseclientfortophatartifactdiscovery to graphite-base/433 July 16, 2026 16:49
@kieran-osgood-shopify
kieran-osgood-shopify changed the base branch from graphite-base/433 to main July 16, 2026 16:50
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/07-10-refactorextractsharedbrowserstackclientandreusehttpclient branch from 77d01c6 to 06412de Compare July 16, 2026 16:51
@kieran-osgood-shopify
kieran-osgood-shopify merged commit 5c6c3a0 into main Jul 16, 2026
27 of 28 checks passed
@kieran-osgood-shopify
kieran-osgood-shopify deleted the kieran-osgood/07-10-refactorextractsharedbrowserstackclientandreusehttpclient branch July 16, 2026 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

#gsd:50662 Rebase Checkout Kit on UCP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants