Skip to content

[Tophat] feat: add the ability to wait for a build to complete#434

Merged
kieran-osgood-shopify merged 1 commit into
mainfrom
kieran-osgood/07-10-feataddtheabilitytowaitforabuildtocomplete
Jul 16, 2026
Merged

[Tophat] feat: add the ability to wait for a build to complete#434
kieran-osgood-shopify merged 1 commit into
mainfrom
kieran-osgood/07-10-feataddtheabilitytowaitforabuildtocomplete

Conversation

@kieran-osgood-shopify

@kieran-osgood-shopify kieran-osgood-shopify commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

What changes are you making?

dev tophat relied on being run after the artifacts are populated on a PR, and would fail if they weren't available.

This PR adds --wait and and interactive option to wait for the new build, or to select a pre-existing build (highlighting to the user that the build is stale to the latest SHA)

This also enables triggering a build on a PR if a build isn't yet available.

How to test


Before you merge

Important

  • I've added tests to support my implementation
  • I have read and agree with the Contribution Guidelines
  • I have read and agree with the Code of Conduct
  • I've updated the relevant platform README (platforms/swift/README.md and/or platforms/android/README.md)

Releasing a new Swift version?
  • I have bumped the version in ShopifyCheckoutKit.podspec
  • I have bumped the version in platforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swift
  • I have updated the SwiftPM/CocoaPods version snippets in platforms/swift/README.md (major version only)
Releasing a new Embedded Checkout Protocol version?
  • I have bumped embeddedCheckoutProtocolAndroid in platforms/android/gradle/libs.versions.toml
  • I have updated protocol/languages/kotlin/embedded-checkout-protocol/api/embedded-checkout-protocol.api if the public API changed
Releasing a new Android version?
  • I have bumped checkoutKitAndroid in platforms/android/gradle/libs.versions.toml
  • I have updated the Gradle/Maven version snippets in platforms/android/README.md

Tip

See the Contributing documentation for the full release process per platform.

@kieran-osgood-shopify kieran-osgood-shopify changed the title feat: add the ability to wait for a build to complete [Tophat] feat: add the ability to wait for a build to complete Jul 10, 2026
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/07-10-refactorextractsharedbrowserstackclientandreusehttpclient branch from 522efa6 to a6b3b1f Compare July 10, 2026 11:11
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/07-10-feataddtheabilitytowaitforabuildtocomplete branch 2 times, most recently from e37a985 to edbe63f Compare July 10, 2026 17:02
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/07-10-refactorextractsharedbrowserstackclientandreusehttpclient branch from 4653cdd to aba303d Compare July 13, 2026 12:05
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/07-10-feataddtheabilitytowaitforabuildtocomplete branch 2 times, most recently from 2570056 to cb43c23 Compare July 13, 2026 13:30
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/07-10-refactorextractsharedbrowserstackclientandreusehttpclient branch 2 times, most recently from 0a3c789 to 089eeaf Compare July 13, 2026 14:54
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/07-10-feataddtheabilitytowaitforabuildtocomplete branch from cb43c23 to 42af50e Compare July 13, 2026 14:54
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/07-10-refactorextractsharedbrowserstackclientandreusehttpclient branch from 089eeaf to 52e5fb5 Compare July 15, 2026 10:59
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/07-10-feataddtheabilitytowaitforabuildtocomplete branch from 42af50e to edf3a35 Compare July 15, 2026 11:00
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/07-10-refactorextractsharedbrowserstackclientandreusehttpclient branch from 52e5fb5 to 0214bcf Compare July 15, 2026 16:14
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/07-10-feataddtheabilitytowaitforabuildtocomplete branch from edf3a35 to 2dd744f Compare July 15, 2026 16:14
@kieran-osgood-shopify
kieran-osgood-shopify marked this pull request as ready for review July 15, 2026 16:18
@kieran-osgood-shopify
kieran-osgood-shopify requested a review from a team as a code owner July 15, 2026 16:18
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/07-10-feataddtheabilitytowaitforabuildtocomplete branch from 2dd744f to 7caad5c Compare July 15, 2026 16:43
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/07-10-refactorextractsharedbrowserstackclientandreusehttpclient branch from 0214bcf to 3cd457e Compare July 15, 2026 16:43
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/07-10-feataddtheabilitytowaitforabuildtocomplete branch from 7caad5c to ea40773 Compare July 15, 2026 17:07
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/07-10-refactorextractsharedbrowserstackclientandreusehttpclient branch from 3cd457e to 820a2d7 Compare July 15, 2026 17:07
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/07-10-refactorextractsharedbrowserstackclientandreusehttpclient branch from 820a2d7 to 77d01c6 Compare July 16, 2026 13:41
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/07-10-feataddtheabilitytowaitforabuildtocomplete branch from ea40773 to 68e84aa Compare July 16, 2026 13:41

kieran-osgood-shopify commented Jul 16, 2026

Copy link
Copy Markdown
Contributor Author

Merge activity

  • Jul 16, 4:48 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jul 16, 4:54 PM UTC: Graphite rebased this pull request as part of a merge.
  • Jul 16, 4:54 PM UTC: @kieran-osgood-shopify merged this pull request with Graphite.

@kieran-osgood-shopify
kieran-osgood-shopify changed the base branch from kieran-osgood/07-10-refactorextractsharedbrowserstackclientandreusehttpclient to graphite-base/434 July 16, 2026 16:51
@kieran-osgood-shopify
kieran-osgood-shopify changed the base branch from graphite-base/434 to main July 16, 2026 16:52
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/07-10-feataddtheabilitytowaitforabuildtocomplete branch from 68e84aa to 30695f7 Compare July 16, 2026 16:53
@kieran-osgood-shopify
kieran-osgood-shopify merged commit bc46e10 into main Jul 16, 2026
27 checks passed
@kieran-osgood-shopify
kieran-osgood-shopify deleted the kieran-osgood/07-10-feataddtheabilitytowaitforabuildtocomplete branch July 16, 2026 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

#gsd:50662 Rebase Checkout Kit on UCP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants