[Phase 8] Add E2E path filtering for Bitrise by kieran-osgood-shopify · Pull Request #417 · Shopify/checkout-kit

kieran-osgood-shopify · 2026-07-07T16:13:31Z

Why?

GitHub and Bitrise both need changed-file detection, so we can avoid wasting CI time building ios/android and running e2e suites.

Github uses dorny/paths-filter.
Bitrise has built in support for a regex, it's fairly limited in its specificity and mostly helps guard by slices rather than fine grained filters

To give a similar experience to what we have in github actions, running only the checks relevant for that slice, I've setup a two prong approach:

Bitrise regex to give a coarse grain skip, which entirely skips the bitrise check, this will avoid things like root readme triggering anything (no runtime checking, it will just be omitted, need to confirm whether this will work once we turn this into a required check)
If the flow passes beyond the regex (this includes readme changes if they're nested within a platform directory), each workflow has its own changed files filter script to determine whether it has any matches, it uses an deny-allow-deny approach
File matching:
a. files are **implicitly ** excluded by default
b. explicitly included files will cause the workflow to run
c. unless there is explicit deny, in which case its excluded

This means the first step in the e2e pipeline will run (~15 seconds to run) and determines if any builds/e2e tests need to run, you can see here it quickly skips and marks a green bitrise check

What?

.github/filters/platform-non-docs.yml moved to .ci/changed-file-filters.yml for re-use across bitrise and .github
Adds focused scripts/changed_file_filters / scripts/lib/changed_file_filters.rb helpers for reusable changed-file filter evaluation outside GitHub Actions where we cannot use dorny/paths-filter.
Updates the Bitrise E2E run-plan producer to use shared filter groups from .ci/changed-file-filters.yml.
Adds a coarse Bitrise changed_files.regex trigger and uses generated E2E_BUILD_* variables to skip unrelated Bitrise workflows.

How to test

I did some testing with some debug branches here:

https://app.graphite.com/github/pr/Shopify/checkout-kit/462/DEBUG---Dont-review-RN-ts-triggers-E2E
This proved that ios/android kicks off if we change something in platforms/react-native like a typescript file
https://app.graphite.com/github/pr/Shopify/checkout-kit/463/DEBUG-dont-review-RN-docs-skips-E2E
This proves that files like .md are skipped in platforms/react-native
https://app.graphite.com/github/pr/Shopify/checkout-kit/464/DEBUG-dont-review-root-README-does-not-trigger-E2E
changes outside of the bitrise regex dont trigger any kind of pipeline at all (a root Readme change didn't even trigger the first stage of the bitrise pipeline)

shadowenv exec -- ruby e2e/scripts/e2e_matrix_to_browserstack_run_plan validate
shadowenv exec -- ruby e2e/scripts/e2e_matrix_to_browserstack_run_plan expand --changed-file platforms/swift/Sources/Foo.swift
shadowenv exec -- ruby e2e/scripts/e2e_matrix_to_browserstack_run_plan expand --changed-file protocol/languages/typescript/src/generated/Models.ts
shadowenv exec -- scripts/changed_file_filters list --changed-file platforms/react-native/modules/@shopify/checkout-kit-react-native/src/index.ts
shadowenv exec -- ruby -e 'require "yaml"; %w[.github/workflows/ci.yml .github/workflows/package-size.yml .ci/changed-file-filters.yml e2e/config/matrix.yml e2e/bitrise.yml].each { |path| YAML.safe_load_file(path, aliases: true) }; puts "yaml ok"'
shadowenv exec -- bitrise validate --config=e2e/bitrise.yml
shadowenv exec -- /opt/dev/bin/dev check e2e-bitrise-validate

kieran-osgood-shopify · 2026-07-07T16:13:47Z

[Phase 8] Add E2E path filtering for Bitrise #417 : 4 dependent PRs (#462 , #463 , #464 and 1 other) 👈 (View in Graphite)
[Phase 7] Soft-launch E2E PR checks #364 : 1 other dependent PR (#401 )
[Phase 6] Report E2E results to GitHub #363
[Phase 5] Run BrowserStack Maestro from E2E matrix rows #362
[Phase 4] Build React Native iOS E2E IPA artifact #361
[Phase 3] Build React Native Android E2E APK artifact #360
[Phase 2] Add Bitrise E2E pipeline skeleton #357
[Phase1] Add E2E matrix launch smoke foundation #356
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

kieran-osgood-shopify · 2026-07-14T16:41:49Z


 tools:
-  ruby: 3.3.6
+  ruby: installed


Switching this to only apply 3.3.6 to the react-native builds saves us ~3.5mins per CI run

Is the ruby version important to us?

Feels like it could shift about a bit under the hood (if they update the stack to bump dependencies periodically)

They don't change the default version on a stack - bumps are introduced when a new stack is released

I'll check whether I can delete this line - I opted for per workflow overrides to 3.3.6 to improve build time, and so I might be able to get rid of this line now

github-actions · 2026-07-14T17:37:09Z

React Native — Coverage Report

Lines	Statements	Branches	Functions
	91.85% (327/356)	87.98% (183/208)	100% (86/86)

github-actions · 2026-07-14T17:37:14Z

Web — Coverage Report

Lines	Statements	Branches	Functions
	98.8% (248/251)	85.49% (112/131)	98.57% (69/70)

github-actions · 2026-07-14T17:40:29Z

Package Size

Platform	Artifact	Base	Head
Web	npm tarball	65.5 KiB	65.5 KiB
React Native	npm tarball	103.1 KiB	103.1 KiB
Android	release AAR	226.7 KiB	226.7 KiB

Web file breakdown

File	Base	Head
`dist/index.js.map`	184.1 KiB	184.1 KiB
`dist/index.d.ts`	41.9 KiB	41.9 KiB
`dist/custom-elements.json`	40.1 KiB	40.1 KiB
`dist/index.js`	29.6 KiB	29.6 KiB
`README.md`	17.8 KiB	17.8 KiB
`package.json`	2.8 KiB	2.8 KiB
`LICENSE`	1.1 KiB	1.1 KiB

React Native file breakdown

File	Base	Head	Delta
`node_modules/@shopify/checkout-kit-protocol/src/generated/Models.ts`	85.4 KiB	85.4 KiB	0 B
`node_modules/@shopify/checkout-kit-protocol/src/generated/Models.d.ts`	53.0 KiB	53.0 KiB	0 B
`ios/ShopifyCheckoutKit.swift`	15.0 KiB	15.0 KiB	0 B
`ios/AcceleratedCheckoutButtons.swift`	14.0 KiB	14.0 KiB	0 B
`lib/commonjs/index.js`	13.1 KiB	13.1 KiB	0 B
`src/components/AcceleratedCheckoutButtons.tsx`	12.9 KiB	12.9 KiB	0 B
`src/index.ts`	12.5 KiB	12.5 KiB	0 B
`lib/commonjs/components/AcceleratedCheckoutButtons.js`	11.4 KiB	11.4 KiB	0 B
`android/src/main/java/com/shopify/reactnative/checkoutkit/ShopifyCheckoutKitModule.java`	11.1 KiB	11.1 KiB	0 B
`lib/module/index.js`	10.4 KiB	10.4 KiB	0 B
`lib/commonjs/components/AcceleratedCheckoutButtons.js.map`	10.3 KiB	10.3 KiB	0 B
`lib/module/components/AcceleratedCheckoutButtons.js`	10.2 KiB	10.2 KiB	0 B
`node_modules/@shopify/checkout-kit-protocol/src/generated/ProtocolNotifications.ts`	9.5 KiB	9.5 KiB	0 B
`lib/module/components/AcceleratedCheckoutButtons.js.map`	9.1 KiB	9.1 KiB	0 B
`src/index.d.ts`	8.9 KiB	8.9 KiB	0 B
`lib/module/index.js.map`	8.2 KiB	8.2 KiB	0 B
`src/present-dispatcher.ts`	8.0 KiB	8.0 KiB	0 B
`lib/commonjs/index.js.map`	7.7 KiB	7.7 KiB	0 B
`node_modules/@shopify/checkout-kit-protocol/src/generated/ProtocolNotifications.d.ts`	7.6 KiB	7.6 KiB	0 B
`node_modules/@shopify/checkout-kit-protocol/src/generated/ProtocolRenameMap.ts`	7.2 KiB	7.2 KiB	0 B
…and 110 smaller files

Android file breakdown

File	Base	Head
`classes.jar`	239.9 KiB	239.9 KiB
`res/layout/checkout_sheet_content.xml`	4.0 KiB	4.0 KiB
`res/values/values.xml`	1.2 KiB	1.2 KiB
`R.txt`	1.0 KiB	1.0 KiB
`proguard.txt`	798 B	798 B
`AndroidManifest.xml`	578 B	578 B
`res/drawable/close.xml`	431 B	431 B
`res/menu/checkout_menu.xml`	354 B	354 B
`META-INF/com/android/build/gradle/aar-metadata.properties`	157 B	157 B

Measured from the PR base SHA and PR head SHA. The file breakdown shows uncompressed sizes within each package artifact, so individual files do not sum to the compressed artifact total. This comment reports package artifact sizes only; it is not a final app binary-size report.

kiftio · 2026-07-15T08:47:03Z


 tools:
-  ruby: 3.3.6
+  ruby: installed


Is the ruby version important to us?

Feels like it could shift about a bit under the hood (if they update the stack to bump dependencies periodically)

kiftio · 2026-07-15T08:48:43Z


  e2e-build-react-native-ios:
+    tools:
+      ruby: 3.3.6


does this need to match the installed version above?

and the one below

Ruby is in a weird state in the repo right now, I have a ticket to fix it, but basically we have multiple .ruby-version files, react-native pins to 3.3.6 whilst rest of the repo uses 3.4.4

Theres an unfortunate side effect when we use a version that isn't preinstalled on bitrise that it recompiles from source via asdf adding ~3mins per workflow that relies on ruby

These are per job overrides for these two workflows - will be removed once we unify ruby usage

kiftio · 2026-07-15T08:53:06Z

+require "net/http"
+require "uri"
+
+class PullRequestChangedFiles


Could we reuse the JsonHttpClient we added

kiftio · 2026-07-15T09:11:50Z

+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
+      - uses: ruby/setup-ruby@9eb537ca036ebaed86729dcb9309076e4c5c3b74 # v1.314.0


I think everywhere else we hardcode v1.316.0

kiftio · 2026-07-15T09:13:29Z

+      - uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
+      - uses: ruby/setup-ruby@9eb537ca036ebaed86729dcb9309076e4c5c3b74 # v1.314.0
+        with:
+          ruby-version: .ruby-version


Think this resolves to 3.4.4

Apparently we already have 3.3.6 for RN swift, plus installed for bitrise

Do we want to align these all to use .ruby-version and standardize on 1 version (maybe as well as installed)?

I have a ticket here to align ruby across the project https://github.com/shop/issues-checkout-kit/issues/1136 given the ruby scripts it wasn't just a case of bump the version so I decided I'd get the e2e pipe setup for all platforms, then I have that to verify correctness on any changes

kiftio · 2026-07-15T09:15:22Z

+class PullRequestChangedFiles
+  PER_PAGE = 100
+  RETRYABLE_STATUS_CODES = [429, 500, 502, 503, 504].freeze
+  RETRYABLE_EXCEPTIONS = [


Worth adding in a few more?

Suggested change

RETRYABLE_EXCEPTIONS = [

RETRYABLE_EXCEPTIONS = [

Net::OpenTimeout,

Net::ReadTimeout,

Errno::ECONNRESET,

Errno::ECONNREFUSED,

Errno::EHOSTUNREACH,

Errno::ETIMEDOUT,

SocketError,

OpenSSL::SSL::SSLError,

Timeout::Error,

EOFError,

IOError

].freeze

kiftio · 2026-07-15T09:15:59Z

+  def default_transport(uri, headers)
+    request = Net::HTTP::Get.new(uri)
+    headers.each { |key, value| request[key] = value }
+    Net::HTTP.start(uri.host, uri.port, use_ssl: true) { |http| http.request(request) }


should we have a request timeout (open/read)

kieran-osgood-shopify · 2026-07-15T10:38:32Z

Merge activity

Jul 15, 10:38 AM UTC: A user started a stack merge that includes this pull request via Graphite.
Jul 15, 10:40 AM UTC: Graphite rebased this pull request as part of a merge.
Jul 15, 10:58 AM UTC: @kieran-osgood-shopify merged this pull request with Graphite.

Assisted-By: devx/96a590ff-685a-49ce-8199-0810f0ac2379

github-actions Bot added the #gsd:50662 Rebase Checkout Kit on UCP label Jul 7, 2026

kieran-osgood-shopify force-pushed the kieran-osgood/e2e-browserstack/phase-8-path-filters branch from e6803ea to fc3c69a Compare July 7, 2026 16:51

kieran-osgood-shopify commented Jul 7, 2026

View reviewed changes

Comment thread e2e/BITRISE.md Outdated

kieran-osgood-shopify commented Jul 7, 2026

View reviewed changes

Comment thread e2e/BITRISE.md Outdated

kieran-osgood-shopify commented Jul 7, 2026

View reviewed changes

Comment thread e2e/BITRISE.md Outdated

kieran-osgood-shopify changed the base branch from kieran-osgood/e2e-browserstack/phase-7-soft-launch to graphite-base/417 July 8, 2026 10:11

kieran-osgood-shopify mentioned this pull request Jul 8, 2026

[Tophat] Add Bitrise client for Tophat artifact discovery #419

Merged

11 tasks

kieran-osgood-shopify force-pushed the graphite-base/417 branch from 50ae2bd to ac6cc38 Compare July 8, 2026 11:41

kieran-osgood-shopify force-pushed the kieran-osgood/e2e-browserstack/phase-8-path-filters branch from fc3c69a to 5f078b7 Compare July 8, 2026 11:41

kieran-osgood-shopify changed the base branch from graphite-base/417 to kieran-osgood/e2e-browserstack/phase-7-soft-launch July 8, 2026 11:42

kieran-osgood-shopify force-pushed the kieran-osgood/e2e-browserstack/phase-7-soft-launch branch from ac6cc38 to a2c10bc Compare July 8, 2026 15:01

kieran-osgood-shopify force-pushed the kieran-osgood/e2e-browserstack/phase-8-path-filters branch from 5f078b7 to 5c70153 Compare July 8, 2026 15:01

kieran-osgood-shopify force-pushed the kieran-osgood/e2e-browserstack/phase-7-soft-launch branch from a2c10bc to 02227b8 Compare July 8, 2026 15:08

kieran-osgood-shopify force-pushed the kieran-osgood/e2e-browserstack/phase-8-path-filters branch 2 times, most recently from 858b9de to ceb5011 Compare July 8, 2026 16:18

kieran-osgood-shopify force-pushed the kieran-osgood/e2e-browserstack/phase-7-soft-launch branch 2 times, most recently from 92b0cf9 to b7aa8b6 Compare July 8, 2026 17:02

kieran-osgood-shopify force-pushed the kieran-osgood/e2e-browserstack/phase-8-path-filters branch from ceb5011 to b08d7b3 Compare July 8, 2026 17:03

kieran-osgood-shopify force-pushed the kieran-osgood/e2e-browserstack/phase-7-soft-launch branch from b7aa8b6 to c2fc448 Compare July 9, 2026 08:11

kieran-osgood-shopify force-pushed the kieran-osgood/e2e-browserstack/phase-8-path-filters branch from b08d7b3 to 6959ac8 Compare July 9, 2026 08:12

kieran-osgood-shopify force-pushed the kieran-osgood/e2e-browserstack/phase-7-soft-launch branch from c2fc448 to f060ca5 Compare July 9, 2026 09:34

kieran-osgood-shopify mentioned this pull request Jul 14, 2026

DEBUG - Dont review: RN ts triggers E2E #462

Closed

kieran-osgood-shopify force-pushed the kieran-osgood/e2e-browserstack/phase-8-path-filters branch from ce50495 to c9f214c Compare July 14, 2026 16:07

kieran-osgood-shopify mentioned this pull request Jul 14, 2026

DEBUG dont review: RN docs skips E2E #463

Closed

kieran-osgood-shopify force-pushed the kieran-osgood/e2e-browserstack/phase-7-soft-launch branch from 6b12548 to 405986b Compare July 14, 2026 16:33

kieran-osgood-shopify force-pushed the kieran-osgood/e2e-browserstack/phase-8-path-filters branch from c9f214c to 3145aff Compare July 14, 2026 16:33

kieran-osgood-shopify commented Jul 14, 2026

View reviewed changes

kieran-osgood-shopify force-pushed the kieran-osgood/e2e-browserstack/phase-8-path-filters branch from 3145aff to 2b427c7 Compare July 14, 2026 17:08

kieran-osgood-shopify mentioned this pull request Jul 14, 2026

DEBUG dont review : root README does not trigger E2E #464

Closed

kieran-osgood-shopify marked this pull request as ready for review July 14, 2026 17:36

kieran-osgood-shopify requested a review from a team as a code owner July 14, 2026 17:36

kieran-osgood-shopify force-pushed the kieran-osgood/e2e-browserstack/phase-8-path-filters branch from 2b427c7 to 4943887 Compare July 14, 2026 17:46

kiftio reviewed Jul 15, 2026

View reviewed changes

This was referenced Jul 15, 2026

[Phase 10] Add android kotlin E2E test target #465

Merged

[Phase 10] Add Swift E2E target #466

Merged

kieran-osgood-shopify force-pushed the kieran-osgood/e2e-browserstack/phase-8-path-filters branch from 4943887 to 5c3ec74 Compare July 15, 2026 10:21

kiftio approved these changes Jul 15, 2026

View reviewed changes

kieran-osgood-shopify changed the base branch from kieran-osgood/e2e-browserstack/phase-7-soft-launch to graphite-base/417 July 15, 2026 10:38

kieran-osgood-shopify changed the base branch from graphite-base/417 to main July 15, 2026 10:38

Share changed-file filters across CI and E2E

e3737a0

Assisted-By: devx/96a590ff-685a-49ce-8199-0810f0ac2379

kieran-osgood-shopify force-pushed the kieran-osgood/e2e-browserstack/phase-8-path-filters branch from 5c3ec74 to e3737a0 Compare July 15, 2026 10:39

kieran-osgood-shopify merged commit ec2ccd0 into main Jul 15, 2026
37 checks passed

kieran-osgood-shopify deleted the kieran-osgood/e2e-browserstack/phase-8-path-filters branch July 15, 2026 10:58

This was referenced Jul 15, 2026

[CI] Maintenance: align ruby versions #468

Merged

[Tophat] Adds swift/kotlin to tophat install rows #473

Merged

[Bitrise] Failover gracefully when run drifts from main #490

Open

DO NOT MERGE: add phantom E2E target to simulate config/matrix drift #491

Closed

-  RETRYABLE_EXCEPTIONS = [
+ RETRYABLE_EXCEPTIONS = [
+    Net::OpenTimeout,
+    Net::ReadTimeout,
+    Errno::ECONNRESET,
+    Errno::ECONNREFUSED,
+    Errno::EHOSTUNREACH,
+    Errno::ETIMEDOUT,
+    SocketError,
+    OpenSSL::SSL::SSLError,
+    Timeout::Error,
+    EOFError,
+    IOError
+  ].freeze

Uh oh!

Conversation

kieran-osgood-shopify commented Jul 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why?

What?

How to test

Uh oh!

kieran-osgood-shopify commented Jul 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jul 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

React Native — Coverage Report

Uh oh!

github-actions Bot commented Jul 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Web — Coverage Report

Uh oh!

github-actions Bot commented Jul 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Package Size

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kieran-osgood-shopify commented Jul 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

kieran-osgood-shopify commented Jul 7, 2026 •

edited

Loading

kieran-osgood-shopify commented Jul 7, 2026 •

edited

Loading

github-actions Bot commented Jul 14, 2026 •

edited

Loading

github-actions Bot commented Jul 14, 2026 •

edited

Loading

github-actions Bot commented Jul 14, 2026 •

edited

Loading

kieran-osgood-shopify commented Jul 15, 2026 •

edited

Loading